Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2779 closed change (duplicate)

Create a landing page for Microsoft Edge

Reported by: oleksandr Assignee: oleksandr
Priority: Unknown Milestone:
Module: Websites Keywords:
Cc: oleksandr, jobp, saroyanm, sven, annlee@…, sergz, lisabielik Blocked By:
Blocking: Platform: Internet Explorer
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29322769/
https://codereview.adblockplus.org/29323033/

Description (last modified by oleksandr)

Background

We don't have a version of Adblock Plus for Microsoft Edge. Since there is more and more users of that browser we want to have a special landing page for that browser, where users would give their email to be notified when a version of Adblock Plus for Microsoft Edge is available.

What to change

Add another entry into a list of browsers on https://adblockplus.org which would correspond to Microsoft Edge. I think this icon can be used. Change the ABP video which is to the left of the features list to the “coming soon” image for users who are navigating to the page using Microsoft Edge. Make the whole “features” section a bit taller and arrange icons for other browsers horizontally. Add the subscription form with an email field and a "Notify me" button. The form should look like the current subscription form on adblock browser landing page. When a user enters an email and clicks the "Notify me" button a validation email should be sent with a link to validate email. When that link is clicked and everything is fine we should store the email address into a separate file. Details on the verification mechanism are described in #2234.

Validation mail should be plain text and should look like this:
---

To: {{ recipient|mime }}
From: info@…
Subject: Please confirm your Adblock Plus for Microsoft Edge notification
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="UTF-8"

Hello,

Thanks for signing up to get notified of Adblock Plus for Microsoft Edge!
Click the link below to verify your email address.

{{ verification_url }}

You can simply ignore this email if you didn't sign up.

If at any point you decide that you no longer want to be notified, email
info@… and we'll remove you from the notification list.

The Adblock Plus Team

Eyeo GmbH
Im Klapperhof 7-23
50670 Cologne, Germany

E-mail: info@…
Web: https://eyeo.com | https://adblockplus.org

VAT-ID: DE279292414
District Court Cologne: HRB 73508
Managing Directors: Wladimir Palant & Till Faida

---

More info can be found in the project proposal.

Attachments (2)

edge teaser 9 visual.png (52.1 KB) - added by sven 4 years ago.
edge teaser 10 styleguide.png (194.2 KB) - added by sven 4 years ago.

Download all attachments as: .zip

Change History (24)

comment:1 Changed 4 years ago by oleksandr

  • Cc oleksandr jobp added

comment:2 Changed 4 years ago by greiner

  • Cc saroyanm added
  • Ready unset

comment:3 Changed 4 years ago by saroyanm

  • Cc sven added

Create a landing page with the same design as the landing page for Adblock Browser

@oleksandr can you please provide more information. Please provide text for the new page, also what is the Idea with community button ? Are you going to use it or remove it completely ?

Also I think make sense to prepare text for the subscription email I think it's going to be double opt in, for reference you can look on #2234.

Also I'm not sure what are MS plans regarding mobile extensions on edge, if they are going to come together then maybe we can update #2570 to infrastructure and make blocked by current issue, after updating the description to redirect to current LP instead Android Installation page.

comment:4 Changed 4 years ago by oleksandr

  • Cc annlee@… added

comment:5 Changed 4 years ago by oleksandr

  • Blocking 2570 added

comment:6 Changed 4 years ago by oleksandr

  • Blocking 2570 removed
  • Description modified (diff)

I have updated the ticket description with more info. Also I have looped in Ann-Lee to review the text.

As for MS Edge on Windows Mobile - no matter if it supports extensions or not we should still display this landing page for those users as well. So I have modified #2570 as you suggested, thanks.

comment:7 Changed 4 years ago by oleksandr

  • Blocking 2570 added

comment:8 Changed 4 years ago by sergz

  • Cc sergz added

comment:9 Changed 4 years ago by oleksandr

  • Cc lisabielik added
  • Description modified (diff)
  • Owner set to oleksandr
  • Ready set

comment:10 Changed 4 years ago by saroyanm

  • Ready unset

@oleksandr This ticket is not ready yet.
We don't have image yet, also we need text of email and backed service that will handle the Email delivery.

Changed 4 years ago by sven

comment:11 Changed 4 years ago by oleksandr

  • Review URL(s) modified (diff)

comment:12 Changed 4 years ago by philll

I wonder how there can be a review URL if this issue has never been ready. The description is in no way complete. Please get all relevant requirements into the issue description before implementing changes.

Changed 4 years ago by sven

comment:13 Changed 4 years ago by oleksandr

  • Description modified (diff)
  • Review URL(s) modified (diff)

comment:14 Changed 4 years ago by oleksandr

The back end service that handles email verification has been submitted here: https://codereview.adblockplus.org/29323033/. I think this ticket can be set to ready now.

comment:15 Changed 4 years ago by oleksandr

  • Description modified (diff)

comment:16 Changed 4 years ago by oleksandr

  • Description modified (diff)

comment:17 Changed 4 years ago by philll

  • Shall the image replacing the video be displayed to every user visiting adblockplus.org?
  • Which subscription form are you talking about?
  • Under which circumstances shall the described mail be sent out?
  • Shall the dispatched mail be plain text only or include HTML?
  • Where and how shall the email addresses submitted be stored? Who shall have access to it and how?
  • Where is the verification link logic described?

comment:18 Changed 4 years ago by oleksandr

  • Description modified (diff)

comment:19 Changed 4 years ago by saroyanm

Add another entry into a list of browsers on ​https://adblockplus.org which would correspond to Microsoft Edge. I think ​this icon can be used.

I do remember that we decided not to add icon before the actual extension launch, so meanwhile we will think whether we need to replace existing icon or change layout to be able to show more than 8 icons.

the “coming soon” image for users who are navigating to the page using Microsoft Edge

I think the image is not ready yet I do remember discussion that we will need a new image for that to fit the content.

Shall the image replacing the video be displayed to every user visiting adblockplus.org?

No the layout described in the ticket will be only visible for users who are using Edge browser, so it will be another page with url like: https://adblockplus.org/en/edge

Which subscription form are you talking about?

the one in the image I guess.

Under which circumstances shall the described mail be sent out?

We will use basic HTML5 form validation on front end, but meanwhile we will need sitescript ticket which will handle the request and maybe send error back, so we will need error handling which I'll add to the ticket, but it mostly depends how it will be handled on serverside.

Shall the dispatched mail be plain text only or include HTML?
Where is the verification link logic described?
Where and how shall the email addresses submitted be stored? Who shall have access to it and how?

I do belive it should behaves same way as the IOS coming soon subscription.
@Phill I'll create [meta] Issue and make it more descriptive, to address all your comments above.
@Oleksandr Sorry that it takes longer was busy with other Proposals, so please address my two comments above and please confirm the url.

comment:20 Changed 4 years ago by oleksandr

I think I have already answered Phill's questions by modifying the issue description.

@Manvel

  1. I actually don't remember deciding not adding the Edge icon. I think we should add it. We can make the icon list always horizontal, but as it is not in the codereview - they are horizontal only for Edge and Maxthon.
  2. The image is still a bit too short, but as I understood from my communication with Sven it might take a while to make a longer one. I think we can manage with what is available for now.
  3. The change of video to the image will be visible only for Edge users. The url I have suggested in the codereview is https://adblockplus.org/en/edge

comment:21 Changed 4 years ago by saroyanm

  • Resolution set to duplicate
  • Status changed from new to closed

I've created [meta] ticket #2843 which will separate Websites, Sitescript and infrastructure tickets.
So code reviews can be submitted to relevant tickets.

comment:22 Changed 4 years ago by oleksandr

  • Blocking 2570 removed
Note: See TracTickets for help on using tickets.