Opened 3 years ago

Closed 6 months ago

Last modified 6 weeks ago

#2801 closed change (fixed)

Create 'Whitelisted websites' screen and add link to 'Ad blocking' screen

Reported by: annlee@… Assignee: diegocarloslima
Priority: P3 Milestone: Adblock-Browser-for-Android-1.4.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29543774/

Description

Background

Currently, users can whitelist a specific website by checking 'Block Ads on this Site' from the Menu, but there's no way for them to then see which sites they whitelisted, or make changes to this. This should be added.

What to change

Add the text 'Whitelisted websites' to the 'Ad blocking' screen - i.e. Menu > Settings > Ad blocking > Whitelisted websites

Create the 'Whitelisted websites' screen, as seen in this mockup

Add the title text, 'Whitelisted websites' at the top

The sites that the user has already whitelisted should appear next (below the title), as seen in this mockup

Add the text 'Add other websites to whitelist' and arrow to the right, as seen in this mockup

Create the 'Add website to whitelist' screen, as seen in this mockup

Add text 'VIA URL / LINK' at the top
Add a grey line underneath
Add a white text box, with blue border and www.yourURL.com in light grey font inside
Add a light blue box underneath, with text 'Add website to whitelist' in white

Change History (10)

comment:1 Changed 3 years ago by philll

Please note that we only allow domains to be whitelisted there, so the label "VIA URL / LINK" is leading to confusion, as you can see in #1745 for example.

Why does this issue have to be confidential?

comment:2 Changed 3 years ago by philll

  • Sensitive unset

comment:3 Changed 17 months ago by diegocarloslima

  • Owner changed from rjeschke to diegocarloslima

comment:4 Changed 11 months ago by diegocarloslima

  • Priority changed from Unknown to P3

comment:5 Changed 10 months ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 10 months ago by diegocarloslima

  • Milestone Adblock-Browser-for-Android-next deleted

comment:7 Changed 7 months ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Ready set

comment:9 Changed 6 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 6 weeks ago by traynard

  • Verified working set
Note: See TracTickets for help on using tickets.