Opened 4 years ago

Closed 3 years ago

#2802 closed change (fixed)

Dynamically generate tooltips

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords: 2016q1
Cc: Blocked By: #2356, #2668
Blocking: #2355 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29334038/

Description (last modified by greiner)

Background

We implemented the basic tooltip functionality and design for the new options page in #2356. That is enough for adding tooltips to "read more" links on the page but to add tooltips to recommended subscriptions we need to make the tooltip generation more flexible. However, for that we need to have translated descriptions for each of those subscriptions (see #2668).

What to change

  • Use <template> to define a tooltip template based on the HTML structure created in #2356
  • Mark elements with data-tooltip
  • The data-tooltip value represents the ID used for finding the translated texts and the image - if there is one
  • Create a function to dynamically create tooltips for a set of given elements
  • Call that function on page load for elements matching the [data-tooltip] selector
  • Make sure to call that function whenever elements were added to the page that should have a tooltip
    • For recommended subscription the data-tooltip value should be taken from subscriptions.xml (see #2668)
    • For anchor tags in the "Tweaks" section of the Advanced tab the data-tooltip attribute should be added to the tag

Change History (8)

comment:1 Changed 4 years ago by greiner

  • Description modified (diff)

comment:2 Changed 4 years ago by greiner

  • Ready set

comment:3 Changed 4 years ago by greiner

  • Priority changed from Unknown to P3

comment:4 Changed 3 years ago by greiner

  • Owner set to greiner

comment:5 Changed 3 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 3 years ago by sebastian

  • Keywords 2016q1 added

comment:7 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 2802/2358 - Dynamically generate tooltips in options page

comment:8 Changed 3 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.