Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2806 closed change (fixed)

Text changes for various pages within Menu > Settings > Ad blocking

Reported by: annlee@… Assignee: rjeschke
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015081632
Module: Adblock-Browser-for-Android Keywords:
Cc: lisabielik, fhd Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29323321/

Description (last modified by annlee@…)

Background

There are various text errors (grammar, text that's no longer relevant, missing text etc.), these need to be corrected.

What to change

1.) Change title in the third onboarding slide
old text = Be the first
new text = Found a bug?

2.) Add description for 'Ad blocking' on Settings screen
description text = Change ad blocking language, options, default setting

3.) In the Ad blocking screen

Change description for ‘Ad blocking’
old text = Configure your filter subscriptions
new text = Configure your filter lists

Change description for ‘More blocking options’
old text = Disable tracking and malware sites or add custom filter lists
new text = Disable tracking, malware domains, add other filter lists

Change description for ‘Acceptable Ads’
old text = Configure Acceptable Ads
new text = Change default setting to block all ads

4.) Capitalize only the first word in each title in the More blocking options screen
old text = Disable Tracking
new text = Disable tracking

old text = Disable Malware Domains
new text = Disable malware domains

old text = Disable Anti-Adblocking Message
new text = Disable Anti-ad blocking message

old text = Disable Social Media Buttons
new text = Disable social media buttons

5.) Change text in More blocking options screen
old text = Add other blocking list
new text = Add filter list

6.) Change text in this screen
old text = Add other blocking list
new text = Add other filter list

old text = Add filter list from this URL
new text = Add other filter list

Change History (10)

comment:1 Changed 4 years ago by philll

  • Cc lisabielik fhd added

@Lisa: I am almost certain those changes aren't in line with our title caplitalisation.

As extensively discussed in this thread, we agreed on not changing the term "Filter list" by something else until we can proof some other terms to be better.

Add custom blocking list" could lead to the expectation to be able to customize a list itself, which is not possible via Adblock Browser.

comment:2 Changed 4 years ago by annlee@…

@Lisa reviewed this text before I posted to this issue, and I also referred to her style guide, which says only the first word in a title should be capitalized

comment:3 Changed 4 years ago by annlee@…

  • Description modified (diff)

comment:4 Changed 4 years ago by annlee@…

  • Description modified (diff)

comment:5 Changed 4 years ago by annlee@…

consulted with @fhd, changed to 'filter lists' everywhere, except for in the title 'More blocking options', Felix was ok with this

I used 'custom' b/c this was used in previous screens (not by me), in addition to 'other', but if this is misleading, then we should stick with 'other' in all instances, I've made this change to the issue

@Lisa - can you do a final review?

comment:6 Changed 4 years ago by rjeschke

Is the text really:

new text = Disable Anti-ad blocking message

and not:

new text = Disable anti-ad blocking messages

Also, really:

description text = Change ad blocking language, options, default setting

and not:

description text = Change ad blocking language, options, default settings

Again, really:

new text = Disable tracking, malware domains, add other filter lists

and not:

new text = Disable tracking, malware domains or add other filter lists

or:

new text = Disable tracking and malware domains, add other filter lists

(or something like that, it's just that "Disable add other filter list" does not make much sense IMHO)

Last edited 4 years ago by rjeschke (previous) (diff)

comment:7 Changed 4 years ago by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 4 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 4 years ago by fhd

  • Priority changed from Unknown to P2

comment:10 Changed 4 years ago by fhd

  • Milestone set to Adblock-Browser-for-Android-next
Note: See TracTickets for help on using tickets.