Opened 4 years ago

Closed 4 years ago

#2808 closed change (fixed)

Update dependency on adblockplusui repository to revision 3a06b955c3f7

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

#2710 fixed an issue on the first-run page, we need to get this into Adblock Plus for Firefox now. Other changes imported with this dependency update:

  • #1528 - Implemented backend for general tab of new options page
  • #1526 (doesn't affect any code currently used by Adblock Plus for Firefox)
  • #2383 (doesn't affect any code currently used by Adblock Plus for Firefox)
  • #2359 (doesn't affect any code currently used by Adblock Plus for Firefox)
  • #2376 - Implement custom filters functionality in options page
  • #2357 (doesn't affect any code currently used by Adblock Plus for Firefox)
  • #2805 - Only require filterValidation module where necessary

The changes that do affect Adblock Plus for Firefox change messageResponder.js - these changes aren't supposed to have any side-effects but might still affect the first-run page.

What to change

Updating the dependency should be sufficient.

What to test

First-run page functionality.

Change History (1)

comment:1 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.