Opened 4 years ago
Closed 4 years ago
#2816 closed defect (fixed)
EHH button in inspector tool does not work - FF developer edition 41.0a2 (2015-07-23)
Reported by: | mapx | Assignee: | trev |
---|---|---|---|
Priority: | Unknown | Milestone: | Element-Hiding-Helper-1.3.3 |
Module: | Extensions-for-Adblock-Plus | Keywords: | |
Cc: | trev, greiner | Blocked By: | |
Blocking: | Platform: | Firefox | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
https://codereview.adblockplus.org/29322778/ |
Description (last modified by trev)
Environment
windows 7
FF developer edition 41.0a2 (2015-07-23)
ABP 2.6.9.3966
EHH 1.3.2.495
How to reproduce
-go to google.co.uk
-right click "images" top right
-in the inspector window on the highlighted row click the ABP icon (left ABP icon in the inspector panel)
-the "compose element hiding rule" window will be opened but empty
Background
The Inspector panel was made E10S-aware. It no longer accesses the elements directly but rather through wrappers talking to the remote process. These wrappers have an API which is similar to DOM but not quite identical.
Change History (5)
comment:1 Changed 4 years ago by mapx
- Description modified (diff)
comment:2 Changed 4 years ago by trev
- Owner set to trev
- Ready set
comment:3 Changed 4 years ago by trev
comment:4 Changed 4 years ago by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed 4 years ago by trev
- Milestone set to Element-Hiding-Helper-next
- Resolution set to fixed
- Status changed from reviewing to closed
Error message is: "TypeError: element is null"