Opened 4 years ago

Closed 4 years ago

#2822 closed change (fixed)

Add support for new subscription types to sitescripts

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #2668, #2821, #2824 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29325371/

Description

Background

See #2821.

What to change

  • Add "type" attribute to recommendations.xml template
  • Don't output the "unknown type" warning for the types: ads, anti-adblock, other, malware, social, privacy
  • Limit the "recommendation without language" warning to subscriptions with type "ads"
  • Only append a subscription to "supplemented" if it's of the same type as its parent

Change History (6)

comment:1 Changed 4 years ago by greiner

  • Blocking 2824 added

comment:2 Changed 4 years ago by greiner

  • Blocking 2668 added

comment:3 Changed 4 years ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed 4 years ago by greiner

  • Owner set to greiner

comment:5 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.