Opened 4 years ago

Closed 4 years ago

#2823 closed change (fixed)

Display new subscription types on adblockplus.org/subscriptions

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: Blocked By:
Blocking: #1736, #2821 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29326068/
https://codereview.adblockplus.org/29326085/

Description

Background

In #2822 we will add new subscription types to sitescripts. This allows us to distinguish between certain types of subscriptions which we can use to group subscriptions on adblockplus.org/subscriptions.

What to change

  • Add the following headline texts to locales/en/subscriptions.json
    • anti-adblock: Anti ad blocking
    • malware: Malware protection
    • privacy: Privacy protection
    • social: Social media blocking
  • Set table width to 100%
  • Add a Table of Contents by adding "id" attributes to <h2> tags
  • Make sure that subscriptions end up under the appropriate headline - this also applies for supplements in which case they shouldn't be indented

Change History (8)

comment:1 Changed 4 years ago by greiner

See #2994

comment:2 Changed 4 years ago by saroyanm

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 4 years ago by philll

See also #1736

comment:4 Changed 4 years ago by greiner

  • Blocking 1736 added

comment:5 Changed 4 years ago by greiner

  • Owner set to greiner

comment:6 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.