Opened 4 years ago

Closed 21 months ago

#2825 closed change (fixed)

Use new subscription types in subscriptionlist

Reported by: greiner Assignee: arthur
Priority: Unknown Milestone:
Module: Infrastructure Keywords:
Cc: saroyanm, ferris, subscriptionlist@… Blocked By: #2821
Blocking: #1736, #2706, #5158, #5803 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by saroyanm)

Background

We need to distinguish between different subscription types in the new options page. For that we added support for new types in #2821 and make use of those now.

What to change

Change the types of the following subscriptions in the subscriptionlist repository:

  • anti-adblock
    • Adblock Warning Removal List
  • malware
    • Adware filters
    • Malware Domains
    • Spam404
  • privacy
    • EasyPrivacy
  • social
    • Fanboy's Social Blocking List

Add the "recommended" flag to the following subscriptions in the subscriptionlist repository:

  • EasyPrivacy
  • Fanboy's Social Blocking List

Change History (17)

comment:1 Changed 4 years ago by greiner

  • Description modified (diff)

comment:2 Changed 4 years ago by greiner

  • Blocking 1736 added

comment:3 Changed 4 years ago by greiner

  • Component changed from Unknown to Infrastructure

comment:4 Changed 3 years ago by greiner

  • Description modified (diff)

Updated list.

comment:5 Changed 2 years ago by saroyanm

  • Cc saroyanm added

comment:6 follow-up: Changed 2 years ago by ferris

@greiner @saroyanm Can you please outline what needs to be done in the backend/infrastructure for this to happen?

comment:7 Changed 2 years ago by saroyanm

It's about changing types of the mentioned filters in subscriptionlist repository, currently all of them in the repository has "other" as a type. ex.: Malware Domains repository should be marked as "malware" instead of "other".
Updated: And also adding a recommended flag, to the mentioned ones.

Last edited 2 years ago by saroyanm (previous) (diff)

comment:8 in reply to: ↑ 6 Changed 2 years ago by saroyanm

  • Cc ferris added

Replying to ferris:
@ferris: ^

Last edited 2 years ago by saroyanm (previous) (diff)

comment:9 Changed 2 years ago by greiner

  • Description modified (diff)

comment:10 Changed 2 years ago by ferris

  • Cc subscriptionlist@… added

OK, thanks. I don't have access to push anything in those repositories. I'll try adding subscriptionlist@… to cc and see what happens :)

comment:11 Changed 2 years ago by saroyanm

Note: This ticket is blocked by another one still.

comment:12 Changed 2 years ago by greiner

  • Description modified (diff)

We're not going to recommend the "Malware Domains" filter list as part of our new options page so there's no need to mark it as "recommended" at this point. I updated the ticket description accordingly.

comment:13 Changed 22 months ago by saroyanm

  • Description modified (diff)

Updated accordingly as we are going to only "recommend" EasyPrivacy and Fanboy's Social Blocking List on the new options page's General Tab.

comment:14 Changed 21 months ago by saroyanm

  • Blocking 5158 added

comment:15 Changed 21 months ago by saroyanm

  • Blocking 5803 added

comment:16 Changed 21 months ago by arthur

  • Owner set to arthur

comment:17 Changed 21 months ago by arthur

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.