Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2834 closed change (fixed)

Enable CrowdIn translations for adblockplusui

Reported by: greiner Assignee: kzar
Priority: P2 Milestone:
Module: Automation Keywords: 2016q1
Cc: sebastian, kzar, oleksandr Blocked By: #2109
Blocking: #1205, #3656 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29336327/

Description

Background

Since we split off the first-run page from adblockplus and created the adblockplusui repository there has no longer been any synchronization of translations with CrowdIn. This means that there's no way for volunteers to contribute their translations.

Unlike adblockplus and adblockpluschrome, however, adblockplusui doesn't have a release process so it would make sense to integrate the translation synchronization with the existing release build tools of the versions that depend on it to ensure that the strings are always up-to-date when doing a product release.

What to change

  • Create new CrowdIn project for adblockplusui strings
  • Extend build.py and localeTools.py to synchronize adblockplusui strings with the newly created project whenever a release is happening for any of the platforms dependent on adblockplusui

Change History (17)

comment:1 Changed 4 years ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 4 years ago by greiner

  • Blocked By 2109 added

comment:3 Changed 4 years ago by sebastian

  • Cc sebastian kzar added
  • Keywords 2015q1 added

comment:4 Changed 4 years ago by sebastian

  • Keywords 2016q1 added; 2015q1 removed

comment:5 Changed 4 years ago by sebastian

  • Priority changed from P3 to P2

comment:6 Changed 4 years ago by greiner

  • Blocking 1205 added

comment:7 Changed 4 years ago by fhd

For the record, if I understand things correctly, we've done the same thing in Adblock Browser for Android, albeit a bit hacky. Here's the script: https://hg.adblockplus.org/adblockbrowser/file/6ca822ca5b23/translations.py

Would be great if we can turn this into a minimal script that just invokes buildtools there as well.

comment:8 Changed 4 years ago by kzar

  • Owner set to kzar

comment:9 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:10 Changed 4 years ago by kzar

The first review only covers supporting Crowdin synchronisation for the adblockplusui repository.

If we really want to make the synchronisation happen automatically at the time of an adblockpluschrome / adblockplus release it will require further changes. I would argue that it is probably a bad idea however. I think it would make more sense to add steps to the release checklists to ensure that the adblockplusui translations are kept up to date.

Last edited 4 years ago by kzar (previous) (diff)

comment:11 Changed 4 years ago by oleksandr

  • Cc oleksandr added

comment:12 Changed 4 years ago by oleksandr

  • Blocking 3656 added

comment:13 follow-up: Changed 4 years ago by kzar

https://hg.adblockplus.org/adblockplusui/rev/81e08dd9d89c

(Up to you Thomas if you consider this fixed now, or if the synchronisation has to be automatic first. See my previous comment.)

comment:14 in reply to: ↑ 13 Changed 4 years ago by greiner

Replying to kzar:

Up to you Thomas if you consider this fixed now, or if the synchronisation has to be automatic first. See my previous comment.

As you suggested, triggering it manually and adding this step to the release checklist should already be sufficient, I think, so no need for automation if there's no added value.

comment:15 Changed 4 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:16 Changed 4 years ago by sebastian

I'm not sure how the workflow should look like. But another step in the release checklist sounds like a bad idea. Though, I'm not sure how you'd automate the synchronization. But regardless of the manual vs automated argument, dependency updates nowadays usually happen independent of the release cycle. Considering adblockplusui in the release process of our products would be a step backwards. Besides making the release process even more complicated, this would also imply quite some dependencies which simply don't scale. For example code freeze of any our products would escalate to ablockplusui, with a few more products adblockplusuibeeing permanently in code freeze, just to point out one issue.

comment:17 Changed 4 years ago by oleksandr

I don't think having another step in the release checklist would be the worst idea. I don't think a code freeze of any of our products would trigger a permanent code freeze for adblockplusui. The products using adblockplusui would merely freeze the reference to the specific revision of adblockplusui, with no requirement for freezing the changes to adblockplusui as I see it.

Note: See TracTickets for help on using tickets.