Opened 5 years ago

Closed 5 years ago

#2836 closed defect (fixed)

Regressions introduced in #2814 due to #2835

Reported by: matze Assignee: matze
Priority: P1 Milestone:
Module: Infrastructure Keywords:
Cc: fred, fhd Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29323001/

Description

The tests before rolling out #2814 where compromised by the VirtualBox issue explained in #2835, which is why the following issues haven't been realized before pushing (but before deployment):

  • The create_resources() function does not properly handle empty records, so we need to differ between the regular ones and the exceptions/exceptionrules prior application
  • The generated sitescripts.ini now misses the outdir

Also, while we have to modify filtermasterserver.yaml again anyway, we may also want to move the repo configuration to private-stub, in order to align that one with the production environment version - now that it won't be that trivial anymore.

Change History (2)

comment:1 Changed 5 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.