Opened 4 years ago

Closed 4 years ago

#2870 closed change (fixed)

Adjust icons on homepage horizontally [adblockplus.org]

Reported by: saroyanm Assignee: oleksandr
Priority: Unknown Milestone:
Module: Websites Keywords:
Cc: sven, oleksandr Blocked By:
Blocking: #2843, #2844, #2874 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29328882/

Description (last modified by saroyanm)

Background

With #2844 we are going to add a new Microsoft Edge Icon to the homepage icons, but while do not have enough space for the icons we will need to do adjust to the existing layout for desktop.

What to change

Adjust Icons as shown in the new layout image:

  • Installation button should occupy available space of the content "right" section.
  • Adjust icons horizontally.

Attachments (1)

edge teaser 10_icons_v6.png (508.0 KB) - added by saroyanm 4 years ago.
new layout

Download all attachments as: .zip

Change History (10)

Changed 4 years ago by saroyanm

new layout

comment:1 Changed 4 years ago by saroyanm

  • Description modified (diff)
  • Summary changed from Adjust icons on homepage horizontally on adblockplus.org to Adjust icons on homepage horizontally [adblockplus.org]

comment:2 Changed 4 years ago by saroyanm

  • Cc sven oleksandr added

@Sven, can you please confirm if the layout image that I've attached to the ticket is the one called V6 ?
Just want to double check just in case.

comment:3 follow-up: Changed 4 years ago by sven

confirmed.

comment:4 in reply to: ↑ 3 Changed 4 years ago by saroyanm

Replying to sven:

confirmed.

Please note in this case we will need to adjust the icons for the to the left specifically for Edge page, what you think can we have them adjusted both in the middle or to the left ?

comment:5 Changed 4 years ago by oleksandr

  • Owner set to oleksandr
  • Ready set
  • Review URL(s) modified (diff)

comment:6 Changed 4 years ago by oleksandr

  • Status changed from new to reviewing

comment:7 Changed 4 years ago by saroyanm

  • Blocking 2874 added

comment:8 Changed 4 years ago by saroyanm

  • Review URL(s) modified (diff)

comment:9 Changed 4 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.