Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2878 closed defect (fixed)

Element Hiding Helper is stuck in a bad state after a tab crash

Reported by: trev Assignee: trev
Priority: P1 Milestone: Element-Hiding-Helper-1.3.3
Module: Extensions-for-Adblock-Plus Keywords: e10s
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29323426/

Description

Environment

Adblock Plus 2.6.10.3969, Element Hiding Helper 1.3.2.497, Firefox 42.0a1 (2015-08-09 nightly), Mac OS X 10.10.

How to reproduce

  1. Go to any website.
  2. Click ABP icon and choose "Select an element to hide".
  3. Kill the Nightly Web Content process via whatever tools your OS provides.
  4. Restore the tabs and repeat step 2.

Observed behaviour

"Error: cannot use a CPOW whose process is gone" messages in Browser Console coming from ​https://hg.adblockplus.org/elemhidehelper/file/1424869523d1/lib/aardvark.js#l396 and ​https://hg.adblockplus.org/elemhidehelper/file/1424869523d1/chrome/content/actor.jsm#l85. Even after restoring the crashed tabs Element Hiding Helper remains in the "selecting" state and cannot abort.

Expected behaviour

Element Hiding Helper should allow selecting in the restored tabs.

Change History (5)

comment:1 Changed 5 years ago by trev

  • Owner set to trev

comment:2 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by trev

  • Keywords e10s added

comment:4 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/elemhidehelper/rev/9631b272a434

comment:5 Changed 5 years ago by trev

  • Milestone set to Element-Hiding-Helper-1.3.3
Note: See TracTickets for help on using tickets.