Opened 3 years ago

Closed 17 months ago

Last modified 14 months ago

#2879 closed change (fixed)

Element Hiding Helper: Move element selection into content process

Reported by: trev Assignee: trev
Priority: P2 Milestone: Element-Hiding-Helper-1.4
Module: Extensions-for-Adblock-Plus Keywords: e10s
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

Description (last modified by trev)


Element selection is currently slow with E10S (multi-process Firefox), the Browser Console is overflowing with "Unsafe CPOW usage" messages. We produce lots of inter-process communication here.

What to change

Set up a child module subsystem from a process script, similar to how Adblock Plus is doing it. Split up the current processScript.js into several modules in the child subsystem as it has three tasks right now: devtools actor, retrieving node info, injecting preview stylesheet. Move aardvark.js parts touching content (mostly displaying element selection and handling of mouse events) into a module in the child subsystem.

Change History (11)

comment:1 Changed 19 months ago by trev

  • Description modified (diff)
  • Owner set to trev
  • Ready set

comment:2 Changed 18 months ago by trev

  • Review URL(s) modified (diff)

comment:3 Changed 18 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 18 months ago by trev

  • Review URL(s) modified (diff)

comment:6 Changed 18 months ago by trev

  • Review URL(s) modified (diff)

comment:8 Changed 17 months ago by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 14 months ago by mapx

The last "stable" EHH is flagged as not compatible with FF multiprocess.
When the current dev build will land as stable ? Did you forget it ?

comment:10 Changed 14 months ago by trev

We are planning to release Element Hiding Helper 1.4 next Tuesday.

comment:11 Changed 14 months ago by Ross

  • Verified working set

Fixed. The "Unsafe CPOW usage" messages no longer appear in the console and EHH appears to work fine in multiprocess Firefox now.

ABP 2.8.2
Firefox 52 / Beta (53.0b9) / Windows 7

Last edited 14 months ago by Ross (previous) (diff)
Note: See TracTickets for help on using tickets.