Opened on 08/10/2015 at 03:10:11 PM

Closed on 12/20/2016 at 03:23:56 PM

Last modified on 04/06/2017 at 12:53:58 PM

#2879 closed change (fixed)

Element Hiding Helper: Move element selection into content process

Reported by: trev Assignee: trev
Priority: P2 Milestone: Element-Hiding-Helper-1.4
Module: Extensions-for-Adblock-Plus Keywords: e10s
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

Description (last modified by trev)


Element selection is currently slow with E10S (multi-process Firefox), the Browser Console is overflowing with "Unsafe CPOW usage" messages. We produce lots of inter-process communication here.

What to change

Set up a child module subsystem from a process script, similar to how Adblock Plus is doing it. Split up the current processScript.js into several modules in the child subsystem as it has three tasks right now: devtools actor, retrieving node info, injecting preview stylesheet. Move aardvark.js parts touching content (mostly displaying element selection and handling of mouse events) into a module in the child subsystem.

Attachments (0)

Change History (11)

comment:1 Changed on 11/15/2016 at 04:29:58 PM by trev

  • Description modified (diff)
  • Owner set to trev
  • Ready set

comment:2 Changed on 11/17/2016 at 08:43:09 AM by trev

  • Review URL(s) modified (diff)

comment:3 Changed on 11/17/2016 at 02:04:47 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 12/01/2016 at 10:51:26 AM by trev

  • Review URL(s) modified (diff)

comment:6 Changed on 12/01/2016 at 11:03:46 AM by trev

  • Review URL(s) modified (diff)

comment:7 Changed on 12/20/2016 at 03:23:08 PM by abpbot

comment:8 Changed on 12/20/2016 at 03:23:56 PM by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed on 03/27/2017 at 08:49:53 AM by mapx

The last "stable" EHH is flagged as not compatible with FF multiprocess.
When the current dev build will land as stable ? Did you forget it ?

comment:10 Changed on 04/04/2017 at 01:40:08 PM by trev

We are planning to release Element Hiding Helper 1.4 next Tuesday.

comment:11 Changed on 04/06/2017 at 12:53:28 PM by Ross

  • Verified working set

Fixed. The "Unsafe CPOW usage" messages no longer appear in the console and EHH appears to work fine in multiprocess Firefox now.

ABP 2.8.2
Firefox 52 / Beta (53.0b9) / Windows 7

Last edited on 04/06/2017 at 12:53:58 PM by Ross

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.