Opened 3 years ago

Last modified 3 years ago

#2926 new change

Support notification opt-out in Internet Explorer

Reported by: oleksandr Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr, sergz, greiner Blocked By: #2925
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by oleksandr)

Background

We want to give our users the possibility to opt-out from notifications. This has already been implemented in other browsers (See #2193). We want to add that functionality to Adblock Plus for Internet Explorer as well.

What to change

Settings page:

  • Add a checkbox to the settings page like shown on the mock-up. It should be hidden by default and only be shown if Prefs.notifications_showui is set to true.

Notification:

  • When clicking the "x" on the top right corner of the notification, the notification content should be replaced with the following two links (see screenshot​):
    • Close this notification: Hide the notification
    • Stop showing notifications: Hide the notification and add "*" to Prefs.notifications_ignoredcategories

When a category is added to the list, set the Prefs.notifications_showui to true.

Attachments (1)

ABP_IE_notifications_opt-out.jpg (329.7 KB) - added by oleksandr 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by oleksandr

comment:1 Changed 3 years ago by oleksandr

  • Description modified (diff)

comment:2 Changed 3 years ago by oleksandr

  • Blocked By 2925 added
  • Cc oleksandr sergz added
  • Description modified (diff)
  • Ready set

comment:3 Changed 3 years ago by greiner

  • Cc greiner added

Whenever the notification is received the plugin should make sure the Prefs.notifications_showui is set to true.

The described behavior is inconsistent with how it works so far. Here's the description from #2192 which implemented it in Core:

Set Prefs.notifications_showui to true when a category is added to the list.

comment:4 Changed 3 years ago by oleksandr

  • Description modified (diff)
  • Priority changed from Unknown to P3

comment:5 Changed 3 years ago by oleksandr

  • Summary changed from Support notification out-out in Internet Explorer to Support notification opt-out in Internet Explorer
Note: See TracTickets for help on using tickets.