Opened 4 years ago

Closed 4 years ago

#2928 closed change (fixed)

Add new icon for touch devices on adblockplus.org and acceptableads.org

Reported by: sven Assignee: saroyanm
Priority: P1 Milestone:
Module: Websites Keywords:
Cc: saroyanm, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29324393/
https://codereview.adblockplus.org/29324389/
https://codereview.adblockplus.org/29324500/
https://codereview.adblockplus.org/29324497/

Description (last modified by sven)

Background

We need 120x120 fav icons for adblockplus.org and acceptableads.org to display these icons on the dashboard.

What to change

Add this fav icon to the adblockplus.org page and this one to the acceptableads.org page.

Attachments (2)

dashboard_aa_v1.png (19.3 KB) - added by sven 4 years ago.
dashboard_abp_v1.png (19.9 KB) - added by sven 4 years ago.

Download all attachments as: .zip

Change History (18)

Changed 4 years ago by sven

Changed 4 years ago by sven

comment:1 Changed 4 years ago by sven

  • Description modified (diff)

comment:2 Changed 4 years ago by saroyanm

Why the priority is P1 ?

comment:3 Changed 4 years ago by saroyanm

  • Summary changed from sssssd to Update favicon on adblockplus.org and acceptableads.org

comment:4 Changed 4 years ago by sven

Because it's a blocker for the Adblock Browser release.

comment:5 Changed 4 years ago by saroyanm

I don't think it's blocker, as far as I know it's just about ABP.org and AA.org bookmarks doesn't look nice.
Do we have that bookmarks there by default ?

comment:6 Changed 4 years ago by sven

@saroyanm it's a blocker, because these two are shown as the default bookmarks on the dashboard.

comment:7 Changed 4 years ago by saroyanm

  • Ready set

Fare enough

comment:8 Changed 4 years ago by saroyanm

  • Owner set to saroyanm

comment:9 Changed 4 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:11 Changed 4 years ago by saroyanm

  • Component changed from Adblock-Browser-for-iOS to Websites

comment:12 Changed 4 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Large Icon for touche devices added to acceptableads.com:
https://hg.adblockplus.org/web.acceptableads.org/rev/7a7c488cdaef

favicon.ico should be uploaded by #2933

comment:13 Changed 4 years ago by saroyanm

  • Summary changed from Update favicon on adblockplus.org and acceptableads.org to Add new icon for touch devices on adblockplus.org and acceptableads.org

comment:14 Changed 4 years ago by saroyanm

  • Cc greiner added
  • Resolution fixed deleted
  • Status changed from closed to reopened

The ticket is reopened while precomposed suffix for apple-touch-icon is not supported by Kitt, make sense to remove that suffix.

comment:15 Changed 4 years ago by saroyanm

  • Review URL(s) modified (diff)
Note: See TracTickets for help on using tickets.