Opened 4 years ago

Closed 4 years ago

#2934 closed defect (worksforme)

Make sure our usage of "let" is correct

Reported by: tschuster Assignee: tschuster
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: Blocked By:
Blocking: #312 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

The current semenatics of let in Firefox are incorrect in some ways. For example
in loops the let binding should be specific to the current iteration. (I am not really good at explaining this, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/let might help)
We need to make sure that our behavior here doesn't change when Firefox changes. Additionally JSHydra doesn't really bother with lets and just replaces them with var. That seems dangerous, especially in the loop case.

Change History (1)

comment:1 Changed 4 years ago by trev

  • Resolution set to worksforme
  • Status changed from new to closed

Resolving this as worksforme - we had a bunch of issues related to this but they have been resolved.

Note: See TracTickets for help on using tickets.