Opened 2 years ago

Last modified 2 years ago

#2944 reviewing change

Improve handling of custom Ruby installation

Reported by: matze Assignee: matze
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: fred Blocked By:
Blocking: #2446 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29324518

Description

The custom installation of Ruby via rvm, while pretty straight-forward, requires a range of improvements in order to increase it's reliability - e.g.:

  • Distribute GPG keys as Puppet resource within the infrastructure repository
  • Distribute any scripts as Puppet resources as well, instead of e.g. downloading them prior to execution
  • Ensure the Ruby installation will not conflict with the system's one, in order to not break Puppet for the next run
  • Ideally make the entire Ruby-setup re-usable (read: introduce a separate ruby module), in order to allow for easier integration of Ruby software in the future
  • Ensure necessary parameters can be set via Hiera (e.g. the Ruby version)

In fact the entire discourse module seems to be broken right now. Yet we have known about some shortcomings before and agreed on improving when necessary already, including a more sophisticated Ruby setup. See #2471 and the associated code-review.

Change History (2)

comment:1 Changed 2 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by matze

  • Blocking 2446 added
Note: See TracTickets for help on using tickets.