Opened 4 years ago

Closed 4 years ago

#2950 closed defect (fixed)

Element Hiding Helper fails in Firefox/Thunderbird 38 and below

Reported by: AlanH Assignee: trev
Priority: P1 Milestone: Element-Hiding-Helper-1.3.4
Module: Extensions-for-Adblock-Plus Keywords:
Cc: trev, greiner, mapx Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29325137/

Description

Environment

OS: Microsoft Windows 8.1 Enterprise
Version: 6.3.9600 Build 9600
Name: Thunderbird
Version: 38.2.0
Application Build ID: 20150813074416
Adblock Plus, 2.6.10, {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}
Element Hiding Helper for Adblock Plus, 1.3.3

How to reproduce

  1. Install Element Hiding Helper
  2. Navigate to Tools->Adblock Plus

Observed behaviour

"Select an element to hide" menu item is missing.

Expected behaviour

"Select an element to hide" menu item appears (possibly greyed out) above "Options" item.

Additional information

Messages appearing in error console when Element Hiding Helper is installed:

Warning: This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1. Source File: https://addons.cdn.mozilla.net/user-media/addons/_attachments/4364/element_hiding_helper_for_adblock_plus-1.3.3-sm+tb+fx.xpi?filehash=sha256%3A4ab20163a5d53f83a074e7bcf74cbedbb6ae51896a699f22ddb98a7a4373709f Line: 0

Signature Verification Error: the signature on this .jar archive is invalid because the certificate used to sign this file has an unrecognized issuer.

1440442334905 addons.xpi WARN Exception running bootstrap method startup on elemhidehelper@adblockplus.org: TypeError: Services.mm is undefined (resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@adblockplus.org.xpi!/bootstrap.js -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@adblockplus.org.xpi!/lib/main.js:51) JS Stack trace: @resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@adblockplus.org.xpi!/bootstrap.js -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@main.js:51:1 < require@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@bootstrap.js:130:7 < startup@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@bootstrap.js:21:3 < XPI_callBootstrapMethod@XPIProvider.jsm:4451:9 < AI_startInstall/<@XPIProvider.jsm:5864:13 < TaskImpl_run@Task.jsm:330:41 < Handler.prototype.process@Promise-backend.js:867:23 < this.PromiseWalker.walkerLoop@Promise-backend.js:746:7 < this.PromiseWalker.scheduleWalkerLoop/<@Promise-backend.js:688:37

1440442334907 addons.xpi WARN Failed to remove temporary file C:\Users\ADMINI~1\AppData\Local\Temp\tmp-94e.xpi for addon https://addons.mozilla.org/thunderbird/downloads/file/336692/element_hiding_helper_for_adblock_plus-1.3.3-sm+tb+fx.xpi?src=api: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: AI_removeTemporaryFile :: line 5113"  data: no] Stack trace: AI_removeTemporaryFile()@resource://gre/modules/addons/XPIProvider.jsm:5113 < AI_startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:5889 < Handler.prototype.process()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:867 < this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:746 < this.PromiseWalker.scheduleWalkerLoop/<()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688 < <file:unknown>

Messages appearing in error console when TB starts with Element Hiding Helper installed:

Warning: ReferenceError: reference to undefined property request.response.preconfigurable

Source File: resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@adblockplus.org.xpi!/bootstrap.js -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@adblockplus.org.xpi!/lib/prefs.js Line: 26

1440447377872 addons.xpi WARN Exception running bootstrap method startup on elemhidehelper@adblockplus.org: TypeError: Services.mm is undefined (resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@adblockplus.org.xpi!/bootstrap.js -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@adblockplus.org.xpi!/lib/main.js:51) JS Stack trace: @resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@adblockplus.org.xpi!/bootstrap.js -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@main.js:51:1 < require@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@bootstrap.js:130:7 < startup@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Administrator/AppData/Local/Thunderbird/Profiles/a4myjudd.TB24+/extensions/elemhidehelper@bootstrap.js:21:3 < XPI_callBootstrapMethod@XPIProvider.jsm:4451:9 < XPI_startup@XPIProvider.jsm:2168:13 < callProvider@AddonManager.jsm:208:12 < _startProvider@AddonManager.jsm:669:5 < AMI_startup@AddonManager.jsm:840:9 < AMP_startup@AddonManager.jsm:2471:5 < AMC_observe@addonManager.js:55:7

Change History (10)

comment:1 Changed 4 years ago by mapx

  • Cc trev greiner added

comment:2 Changed 4 years ago by greiner

  • Component changed from Unknown to Extensions-for-Adblock-Plus
  • Summary changed from TB38: Element Hiding Helper error/failure to Thunderbird: Element Hiding Helper error/failure

This regression was introduced by the changes in #2816. The issue stems from the message manager in Services.jsm being missing.

comment:3 Changed 4 years ago by mapx

  • Cc mapx added

comment:4 Changed 4 years ago by greiner

Note that it works when directly using

Cc["@mozilla.org/globalmessagemanager;1"]
  .getService(Ci.nsIMessageBroadcaster)
  .QueryInterface(Ci.nsIFrameScriptLoader);

instead so it appears that, for some reason, only the "mm" property on the Services variable is missing.

Last edited 4 years ago by greiner (previous) (diff)

comment:5 Changed 4 years ago by trev

  • Priority changed from Unknown to P1
  • Ready set

comment:6 Changed 4 years ago by trev

This affects older Firefox versions as well - Services.mm was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1068087, from Firefox 39 onward.

comment:7 Changed 4 years ago by trev

  • Owner set to trev

comment:8 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 4 years ago by trev

  • Platform changed from Thunderbird to Firefox
  • Summary changed from Thunderbird: Element Hiding Helper error/failure to Element Hiding Helper fails in Firefox/Thunderbird 38 and below

comment:10 Changed 4 years ago by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.