Opened 4 years ago

Closed 4 years ago

#2953 closed defect (fixed)

[unit tests] Cleanup on unload is broken

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29324564/

Description

Environment

Adblock Plus unit tests 1.0.1a.357

How to reproduce

  1. Run unit tests.
  2. Close unit test window while some async test is still running.

Observed behaviour

Error Console shows "QUnit.config.current.testEnvironment.teardown is not a function" and cleanup indeed doesn't run (preferences/filters not restored, HTTP server not shut down). This is fallout from a QUnit update, the API we expect here no longer exists.

Expected behaviour

Cleanup should run as expected.

Change History (2)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.