Changes between Initial Version and Version 6 of Ticket #2956


Ignore:
Timestamp:
11/18/2015 02:03:40 PM (4 years ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2956

    • Property Cc kzar added
    • Property Summary changed from ensure_dependencies.py does not update children of already updated children. to jshydra does not ensure that correct jsshell version is present
    • Property Priority changed from Unknown to P3
    • Property Owner set to kzar
    • Property Keywords jshydra jsshell added
    • Property Ready set
  • Ticket #2956 – Description

    initial v6  
    1 === Environment and how it was reproduced by others === 
    2 After updating of ''libadblockplus'' in ''adblockplusie'' when ''buildtools'' has been updated in ''libadblockplus'' `ensure_dependencies.py` does not update at least `libadblockplus/adblockplus/buildtools/jshydra/`. The further calls of `ensure_dependencies.py` don't help. 
     1=== Description === 
     2The `jshdyra` repository downloads a copy of jsshell if it is not already present in the `mozilla/` directory, but unfortunately it does not check that the version of jsshell is correct. This means that if an old version of jsshell is already present, the new version will not be downloaded. The old version of jsshell will then be used instead, and that can cause problems. 
    33 
    4 === Observed behaviour === 
    5 At least `libadblockplus/adblockplus/buildtools/jshydra/` is obsolete. 
    6  
    7 === Expected behaviour === 
    8 The entire tree should be updated. 
    9  
    10 === Addition thoughts === 
    11 I guess there is a bug in traversing of dependencies, in particular it does not check/process the children of the dependency when that dependency is already updated. 
     4The version of jsshell can be checked with a command like `mozilla/js --help | grep -i version`, the `ensureJsShell()` function in utils.py needs to check the version matches what is expected. If the version doesn't match jsshell should be re-downloaded.