Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#296 closed change (fixed)

[libadblockplus] Don't require custom build step to eliminate thin archives

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5637716494516224/

Description

Background

Currently there is a fairly non-obvious and undocumented build step required to make V8 libraries reusable - one has to convert thin archives into regular archives.

What to change

Inject standalone_static_library flag into V8 configuration to make sure no thin archives are created in the first place.

Change History (4)

comment:1 Changed 6 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 6 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 6 years ago by trev

  • Milestone set to Adblock-Plus-for-Android-next

comment:4 Changed 5 years ago by rjeschke

  • Milestone Adblock-Plus-for-Android-1.3 deleted
  • Platform set to Unknown
Note: See TracTickets for help on using tickets.