Opened 5 years ago

Closed 5 years ago

#298 closed change (fixed)

JSHydra is unable to download a SpiderMonkey build

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4947331774414848
http://codereview.adblockplus.org/5181440375390208

Description

Background

Currently JSHydra will try to download a SpiderMonkey build from https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/17.0.11esr-candidates/build1/ - these builds are gone however. We currently cannot switch to newer releases because of parser changes that will rewrite loops into let statements.

What to change

It seems that we should go with a random nightly instead of using release candidates, nightlies stay on the download servers forever.

Change History (8)

comment:1 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 5 years ago by trev

  • Resolution fixed deleted
  • Status changed from closed to reopened

As noted in http://codereview.adblockplus.org/6256752412590080/, we no longer need to stay with outdated SpiderMonkey builds. Reopening, we should be using something more current then.

comment:4 Changed 5 years ago by tschuster

I would suggest we use the latest stable release, based on Fx 24. Sadly at least right now we can't directly use one of the offical releases of mozjs, because those don't actually include a shell.

For now we could use https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-esr24/, but I am not sure how long that URL stays alive.

comment:5 Changed 5 years ago by trev

That's the problem, this URL won't stay alive. We had to change URLs several times already, I'd rather stop doing this. It's like this:

It seems that we have to use a nightly, that's the only reliable option - we should change the URL when we want it, not when we have to because the build disappeared. I wouldn't go with latest-*, it should be a specific build where we know that everything works. The question is merely whether we go with trunk (31.0a1) or current release (28.0), I don't really have a preference here as long as they produce the same results.

comment:6 Changed 5 years ago by tschuster

The best thing that I have been able to find so far is Aurora builds. I couldn't find anything like latest-release or beta or even esr.

https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-aurora/

comment:7 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

You are right, it seems that nightly builds for release branches are no longer being created (other than debug builds which we shouldn't use). So we basically have the choice between ESR, trunk and Aurora. I tested the ESR build from https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-14-00-05-01-mozilla-esr24/ and it produces exactly the same results, so I guess we can go with it.

Concerning the issue mentioned in the issue description that prevents us from using newer SpiderMonkey builds - turns out I fixed it a year ago. So it's not exactly surprising newer builds work correctly.

comment:8 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.