Opened on 09/03/2015 at 06:30:34 PM

Closed on 09/04/2015 at 08:52:29 AM

#2986 closed change (fixed)

[build] Configure distribution mode in config.py

Reported by: fhd Assignee:
Priority: P3 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015090419
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29325912/

Description

Background

distribution_mode is currently a parameter of build.py. There's no real point to that: The mozconfig is picked based on the distribution mode, so it should normally not change.

What to change

Move the distribution_mode parameter of build.py into config.py.

Attachments (0)

Change History (2)

comment:1 Changed on 09/03/2015 at 06:38:54 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/04/2015 at 08:52:29 AM by fhd

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.