Changes between Version 4 and Version 13 of Ticket #2992


Ignore:
Timestamp:
03/08/2016 01:28:43 PM (4 years ago)
Author:
kzar
Comment:

You're both right, those files aren't actually being generated by cms.bin.generate_static_pages at all. Appears to be a CMS issue instead of a problem with the Nginx config.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2992

    • Property Status changed from reviewing to reopened
    • Property Priority changed from P3 to Unknown
    • Property Keywords cms added
    • Property Cc matze kzar sebastian added
    • Property Component changed from Websites to Sitescripts
    • Property Summary changed from link errors on FAQ - Basic functionality. to [CMS] Animation XML files not generated for non English languages
  • Ticket #2992 – Description

    v4 v13  
    1 === Environment === 
    2 I think it is the same for all environment. 
    3  
    41=== How to reproduce === 
    5  1. Go to https://adblockplus.org/en/faq_basics  
    6  2. Click the flag to change site to no english language (french for example). 
    7  3. Click the green triangle icon [[Image(http://i.imgur.com/0rDRZ0t.png)]] to play animation. 
     2 1. Go to https://adblockplus.org/fr/faq_basics  
     3 2. Click [[Image(http://i.imgur.com/0rDRZ0t.png)]] '''Me montrer comment faire''' link to play the animation.  
    84 
    95=== Observed behaviour === 
    10 No animation demo for no english faq. 
     6No animation is played because the background request to https://adblockplus.org/fr/animations/blockbanner.xml returns 404. 
    117 
    128=== Expected behaviour === 
    13 '''blockbanner.xml''' file link to '''404''' not found! 
     9The animation should play and the XML file should be returned successfully. 
    1410 
    15 https://adblockplus.org/js/animation.js 
     11(For an example of what it should look like start the CMS test server locally and then browse to http://localhost:5000/fr/faq_basics and http://localhost:5000/fr/animations/blockbanner.xml ) 
    1612 
    17 {{{ 
    18 var ns = "https://adblockplus.org/animation"; 
    19 var loadPrefix = "animations/"; 
    20 var loadSuffix = ".xml"; 
    21 }}} 
     13=== Notes === 
    2214 
    23 https://adblockplus.org/forum/viewtopic.php?f=9&t=40258 
     15 - While the test server works properly, `cms.bin.generate_static_pages` doesn't seem to generate the animation XML files for other languages at all. 
     16 - See the related forum post https://adblockplus.org/forum/viewtopic.php?f=9&t=40258 
  • Ticket #2992 – Review URL(s)

    v4 v13  
    1 https://codereview.adblockplus.org/29337838/