Opened 4 years ago

Closed 4 years ago

#3004 closed change (invalid)

Properly set the default search engine to Baidu for Chinese users

Reported by: fhd Assignee: rjeschke
Priority: P2 Milestone: Adblock-Browser-for-Android-1.1.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29326170/

Description

Background

As of #3003, DuckDuckGo is the default search engine for all locales.
Chinese users currently cannot use our default search engine, DuckDuckGo, at all. We need to set Baidu as the default for them.

What to change

We currently use a special build for Chinese users that will use Firefox's country detection and properly pre-select Baidu. This is, however, logic that should be within the app itself: It should select Baidu for Chinese users, and DuckDuckGo for everybody else. The geolocation lookup is not necessary, it suffices to do this based on the user's locale.

Change History (10)

comment:1 Changed 4 years ago by fhd

  • Milestone set to Adblock-Browser-for-Android-next

comment:2 Changed 4 years ago by rjeschke

  • Owner set to rjeschke

comment:3 Changed 4 years ago by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 4 years ago by rjeschke

  • Blocking 3036 added

comment:5 Changed 4 years ago by rjeschke

  • Blocking 3037 added

comment:6 Changed 4 years ago by fhd

One could argue that this was superseeded by #3047 - I suggest we close this one and have #3047 block the issues this one is blocking, instead.

comment:7 Changed 4 years ago by rjeschke

  • Blocking 3037 removed

comment:8 Changed 4 years ago by rjeschke

  • Blocking 3036 removed

comment:9 Changed 4 years ago by rjeschke

Closed for not being relevant any more.

comment:10 Changed 4 years ago by rjeschke

  • Resolution set to invalid
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.