Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#301 closed change (fixed)

Replace for each loops by for of loops

Reported by: tschuster Assignee: tschuster
Priority: P3 Milestone: Adblock-Plus-2.6-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev, thomas@… Blocked By: #764
Blocking: #312 Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6341149593698304/
http://codereview.adblockplus.org/6256752412590080/
http://codereview.adblockplus.org/6423769060999168/

Description

Background

We are currently using for each loops extensively. This JavaScript feature is Mozilla-only and deprecated however.

What to change

Use for...of loops, these have the same functionality but are standardized. They are supported starting with Firefox 13 which is good enough for us.

Change History (12)

comment:1 Changed 6 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 6 years ago by tschuster

I the person working on this, I think I can't assign this to myself.

comment:3 Changed 6 years ago by trev

  • Cc trev added
  • Owner set to tschuster
  • Reporter changed from trev to tschuster
  • Status changed from reviewing to assigned

comment:4 Changed 6 years ago by tschuster

  • Blocking 312 added

comment:5 Changed 6 years ago by tschuster

  • Review URL(s) modified (diff)

comment:6 Changed 6 years ago by greiner

  • Cc thomas@… added

comment:8 Changed 6 years ago by trev

I realized that we are also converting a few for each loops in libadblockplus. I am addressing this as part of my changes in #189.

comment:9 Changed 6 years ago by trev

Same goes for the adblockpluschrome repository, also addressing this in #189.

comment:10 Changed 6 years ago by philll

  • Status changed from assigned to new

The assigned state will be dropped by #403

comment:11 Changed 6 years ago by trev

  • Milestone set to Adblock-Plus-2.6-for-Firefox
  • Resolution set to fixed
  • Status changed from new to closed

comment:12 Changed 5 years ago by trev

  • Blocked By 764 added
Note: See TracTickets for help on using tickets.