Opened 4 years ago

Closed 4 years ago

#3015 closed change (fixed)

Remove legacy code for Adblock Browser iOS email notifcation

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By: #3013
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29326122

Description (last modified by sebastian)

Background

With #2234 we added a WSGI app to sign up with your email address to be notified when Adblock Browser for iOS is available. Adblock Browser has just been released. But with #2846, the WSGI app has been extended to be reused for the Microsoft Edge landing page. However, there are some Adblock Browser specific bits in there, that can be removed as soon as the old landing page is gone by #3013.

What to change

Remove Adblock Browser specific code from the submit_email module, the corresponding email template and the related entries in .sitescripts.example.

Change History (3)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by sebastian

  • Description modified (diff)

comment:3 Changed 4 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.