Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#3022 closed change (fixed)

Add new notification type for normal messages

Reported by: greiner Assignee: greiner
Priority: P2 Milestone: Adblock-Plus-1.9.3-for-Chrome-Opera-Safari-next
Module: Platform Keywords:
Cc: fhd, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29326181/

Description (last modified by greiner)

Background

When first testing the notification mechanism for promoting Adblock Browser we found out that, on Chrome, most people were noticing that notification either not at all or only days later. Therefore we want to introduce a new notification type for normal (i.e. low-severity) messages.

What to change

"normal"-type notifications should

  • trigger a desktop notification
  • not cause the icon to animate
  • not show up in the icon popup
  • apart from the points above behave like "information"-type notifications

What to test

You could set up a local static server which provides a JSON file containing a single notification of a specific type. You could then replace "https://notification.adblockplus.org/notification.json" in lib/prefs.js with the address to that JSON file and re-/install the extension to automatically trigger the request with a short delay to show the expected notification.

The expected behavior is as follows:

  • type=critical:
    • Animate icon with its "!"-variant.
    • Show red notification in icon popup.
    • Show a desktop notification.
  • type=normal:
    • Show a desktop notification.
  • type=information:
    • Animate icon with its "?"-variant.
    • Show a blue notification in icon popup.
  • type=(other):
    • Show a black notification in icon popup.
  • No type:
    • Show a black notification in icon popup.

To test notifications of type "question" you can just browse to http://wwwok.at which should trigger a desktop notification.

Change History (8)

comment:1 Changed 2 years ago by sebastian

  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 2 years ago by greiner

  • Owner set to greiner

comment:3 Changed 2 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 years ago by greiner

  • Description modified (diff)

comment:5 Changed 2 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 2 years ago by greiner

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next

comment:7 Changed 2 years ago by Ross

Just noting that I've mostly tested this in Chrome/Opera and the new notification type (and previous) ones are behaving as described/correctly. Safari to do.

comment:8 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Normal type of notification works as described.

ABP 2.6.0.3979-beta
Firefox 40.0.3 / Windows 7 - 32bit
Firefox 40.0.3 / Ubuntu 14.04 - 64bit

ABP 1.9.2.1482
Chrome 45.0.2454.93 m / Windows 7 - 32bit
Chrome 45.0.2454.93 m / OS X 10.9
Opera 32.0.1948.25 / Windows 7 - 32bit
Safari 7.0.6 / OS X 10.9

Note: See TracTickets for help on using tickets.