Opened 4 years ago

Closed 4 years ago

#3023 closed defect (fixed)

Returning to the homepage resets the language on adblockbrowser.org

Reported by: sebastian Assignee: juliandoucette
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29334188/

Description

Environment

Chrome 46 (effects other browsers as well)

How to reproduce

  1. Go to https://adblockbrowser.org
  2. Scroll down and select a different language, e.g. "Deutsch"
  3. Click on the Adblock Browser logo in the upper left corner

Observed behaviour

The language prefix is removed from the URL and you see the website again in your browser's language.

Expected behaviour

The language should be preserved when switching back to the homepage.

Change History (6)

comment:1 Changed 4 years ago by saroyanm

  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 4 years ago by juliandoucette

  • Owner set to juliandoucette

comment:3 Changed 4 years ago by juliandoucette

This issue exists on adblockplus.org too

I created this ticket for that issue https://issues.adblockplus.org/ticket/3555#ticket

Last edited 4 years ago by juliandoucette (previous) (diff)

comment:4 Changed 4 years ago by sebastian

Hehe, I were about to say the same, just now when I saw that you started to work on this.

The problem in both cases is that the href attribute is hard-coded rather than using 'index'|linkify.

comment:5 Changed 4 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 4 years ago by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.