Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#3034 closed defect (fixed)

Google AdSense for Search ads not showing up with Acceptable Ads enabled

Reported by: arthur Assignee: kzar
Priority: P1 Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords: AcceptableAds
Cc: sebastian, kzar, mario Blocked By:
Blocking: Platform: iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29349337/

Description

Environment

  • iPhone 6 Plus with iOS 9.0 (13A4325c)
  • Adblock Plus for Safari iOS Version 1.0 (1)
  • Acceptable Ads enabled

How to reproduce

  1. Open Adblock browser
  2. Go to ​http://www.gutefrage.net/
  3. Tap on the hamburger menu on the top left
  4. Search for "iphone"

Observed behaviour

Google AdSense for Search ads at the top of the search results don't display properly. The actual links are missing.

Expected behaviour

Google AdSense for Search ads at the top of the search results should be visible properly with links.

Change History (15)

comment:1 Changed 4 years ago by fhd

  • Priority changed from Unknown to P1

Apparently not working on any site - P1.

comment:2 Changed 4 years ago by fhd

  • Owner set to fhd
  • Ready set

comment:3 Changed 4 years ago by fhd

  • Owner fhd deleted

Unassigning myself for now - I'm not actually working on this right now, even though it's high on my list. Anyone who wants to do it though, go ahead.

comment:4 Changed 4 years ago by philll

  • Platform changed from Unknown / Cross platform to iOS

Added newly available platform value.

comment:5 Changed 3 years ago by mario

  • Keywords AcceptableAds added

comment:6 Changed 3 years ago by kzar

  • Cc sebastian kzar mario added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 3 years ago by kzar

  • Owner set to kzar

comment:8 Changed 3 years ago by kzar

(This appears to no longer be a problem when using a new content blocking list that was generated from an up to date easylist.txt, exceptionrules.txt and abp2blocklist. At least not for the given example site gutefrage.net.)

comment:9 follow-up: Changed 3 years ago by kzar

Arthur could you clarify, are these "Google AdSense for Search" ads supposed to be whitelisted for all domains, just gutefrage.net or a list of domains?

comment:10 in reply to: ↑ 9 Changed 3 years ago by arthur

Replying to kzar:

Arthur could you clarify, are these "Google AdSense for Search" ads supposed to be whitelisted for all domains, just gutefrage.net or a list of domains?

In this case it's specifically whitelisted for gutefrage.net but I could provide some other examples if you like.

comment:11 Changed 3 years ago by kzar

So we whitelist these adverts for only certain domains, not for all websites? In that case, yes please, could you give me the entire list so that I can whitelist them all?

comment:12 Changed 3 years ago by arthur

It seems these search ads have been whitelisted globally recently. So there is no need to whitelist specific sites.

comment:13 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 3034 - Fix Google's "AdSense for Search" ads

comment:14 Changed 3 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:15 Changed 3 years ago by mario

  • Milestone set to Adblock-Plus-for-iOS-next

Batch-adjusted milestone for upcoming release of ABP for iOS.

Note: See TracTickets for help on using tickets.