Opened 5 years ago

Last modified 5 years ago

#303 closed change

Don't load element hiding rules — at Version 2

Reported by: fhd Assignee:
Priority: P2 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: jobp@…, arthur, trev Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4980445527670784/
http://codereview.adblockplus.org/6680224334872576/

Description (last modified by fhd)

Background

Element hiding is currently disabled, mainly to save memory. However, ever since we moved to libadblockplus, element hiding rules are being kept in memory again.

What to change

Don't load any element hiding filters.

Once element hiding is properly disabled, we can create an issue for enabling it again. But before we can do that, we need to make sure that the elemhide filter option works, that we don't cause blank pages in Chrome, and ideally we should have reduced memory usage significantly with #145.

Change History (2)

comment:1 Changed 5 years ago by fhd

  • Description modified (diff)

comment:2 Changed 5 years ago by fhd

  • Description modified (diff)
Note: See TracTickets for help on using tickets.