Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3047 closed change (fixed)

Change default search engines

Reported by: fhd Assignee: rjeschke
Priority: P2 Milestone: Adblock-Browser-for-Android-1.1.0
Module: Adblock-Browser-for-Android Keywords:
Cc: vickyyu Blocked By: #3036
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29327949/

Description (last modified by fhd)

Background

We currently have a lot of search engines available by default. We want to reduce this to a less overwhelming amount, and reduce country/locale specific differences.

What to change

In all countries except China, the default search engines should be, in that order:

  1. DuckDuckGo
  2. Yahoo
  3. Google
  4. Wikipedia
  5. Amazon

China needs a special case, since most Chinese cannot access some or all of these. So just in China, it should be:

  1. Baidu
  2. DuckDuckGo
  3. Yahoo
  4. Google
  5. Wikipedia
  6. Amazon

In either case:

  • It's fine to skip search engines currently not available in the specific locales, it should fall back to the next one in the list.
  • Only the first three search engines have to be in the order specified, for those below it doesn't matter.

We can surely refine this over time, based on what search engines people in specific countries find particularly useful, but this should do for now.

We should test this to ensure that this change doesn't change anyone's configured search engine. Two cases two consider:

  1. If they changed the search engine to something that was previously on the list, but not anymore, e.g. Bing.
  2. If they added an additional search engine, e.g. ixquick.
  3. If they had a default configured for them that is now not longer available. Yandex for Russian locales might be such a case.

Change History (12)

comment:1 Changed 4 years ago by rjeschke

  • Owner set to rjeschke

comment:2 Changed 4 years ago by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by fhd

  • Description modified (diff)

comment:4 Changed 4 years ago by fhd

  • Description modified (diff)

comment:5 Changed 4 years ago by rjeschke

  • Blocked By 3036 added

comment:6 Changed 4 years ago by rjeschke

  • Blocking 3037 added

comment:7 Changed 4 years ago by rjeschke

  • Blocked By 3036 removed

comment:8 Changed 4 years ago by rjeschke

  • Blocked By 3036 added

comment:9 Changed 4 years ago by vickyyu

  • Cc vickyyu added

comment:10 Changed 4 years ago by rjeschke

  • Blocking 3037 removed

comment:11 Changed 4 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed 4 years ago by fhd

  • Milestone set to Adblock-Browser-for-Android-next
Note: See TracTickets for help on using tickets.