Opened 4 years ago

Closed 4 years ago

#3048 closed defect (fixed)

Clients don't stay in test group if notification is inactive

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: sporz, kirill Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29327106/

Description

Environment

sitescripts revision 9286a9834488.

How to reproduce

  1. Set up a notification with at least one variant, and in addition either the start parameter set to the future, the end parameter set to the past, or the inactive parameter set to True.
  2. Make a notification request with lastVersion set to 197001010000-a/0, e.g. `https://notification.adblockplus.org/.

Observed behaviour

version doesn't end in -a/0.

Expected behaviour

In the response, version should end in -a/0.

Change History (5)

comment:1 Changed 4 years ago by fhd

  • Owner set to fhd

comment:2 Changed 4 years ago by Kirill

  • Cc sporz kirill added

comment:3 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 4 years ago by Ross

  • Verified working set

The variations described are all working (inactive=true, start in future, end in past).

issue-3048.patch
infrastructure-git / upstream / 5a8350483c0d0d3aadf7432bbdf34d92a7190582

comment:5 Changed 4 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.