Opened 5 years ago

Closed 12 months ago

#3055 closed change (rejected)

Fix inconsistencies with critical notifications

Reported by: greiner Assignee:
Priority: P3 Milestone:
Module: Platform Keywords: closed-in-favor-of-gitlab
Cc: Ross, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)


There are a couple of user experience inconsistencies with critical notifications that were discovered while testing those. Critical notifications are not supposed to be closed or opted-out of. This should be reflected across the various display methods.

What to change

  • Don't stop the icon animation (as implemented in #3096) if it's a critical notification.
  • Don't show "close" button in the icon popup for critical notifications.
  • Closing the desktop notification should not hide the notification in the icon popup for critical notifications.

Change History (6)

comment:1 Changed 5 years ago by greiner

  • Description modified (diff)

There's now a separate ticket for stopping the icon animation (see #3096) so I modified the description accordingly.

comment:2 Changed 5 years ago by greiner

  • Cc Ross added

comment:3 Changed 5 years ago by kzar

Perhaps this issue should be turned into a meta issue containing a list of issues that need to be resolved? At the moment it is fairly vague, so I don't feel I can mark it as ready.

comment:4 Changed 5 years ago by greiner

I didn't go into further technical detail because none of those changes require fundamental changes to the extension - overall they're pretty trivial (mostly about adding if-statements where appropriate).

comment:5 Changed 5 years ago by sebastian

  • Cc sebastian added
  • Priority changed from Unknown to P3
  • Ready set

If you don't want to split this up into multiple issues fine with me. But please consider splitting it up in multiple reviews/commits though. Otherwise these changes sound reasonable.

comment:6 Changed 12 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.