Opened 22 months ago

Closed 6 days ago

#3063 closed change (fixed)

Back out fix for #3050, fix it in the conversion script

Reported by: fhd Assignee: mjethani
Priority: P1 Milestone:
Module: Adblock-Plus-for-iOS Keywords:
Cc: mario Blocked By:
Blocking: Platform: iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

We have landed a hot fix for #3050 that modified easylist_with_acceptable_ads.json directly. While that has the same effect as far as google.com is concerned, it's a hack, and we really ought to fix this in the conversion script instead of having to make manual changes to the generated JSON.

What to change

Work around #3050 in the conversion script.

Change History (6)

comment:1 Changed 21 months ago by philll

  • Platform changed from Unknown / Cross platform to iOS

Added newly available platform value.

comment:2 Changed 20 months ago by fhd

  • Resolution set to duplicate
  • Status changed from new to closed

Considering that that #3050 was reopened and the change reverted, this issue is redundant now. We can just solve it properly in #3050.

comment:3 Changed 11 months ago by mario

  • Cc mario added
  • Resolution duplicate deleted
  • Status changed from closed to reopened

Reopened as #3050 was -- again -- fixed by applying a workaround (due to trying to fix this on short notice). Said workaround has been tested and works find and thus will stay in place until a proper fix was introduced.

comment:4 Changed 6 days ago by mjethani

This was already fixed in changeset 36bcf3e032cc in abp2blocklist. The code now correctly generates the following rule for the @@||googleadservices.com^$document filter:

{ 
  "trigger": {
    "url-filter": ".*",
    "if-domain": [
      "*googleadservices.com"
    ]
  },
  "action": {
    "type": "ignore-previous-rules"
  }   
}

Which would accomplish exactly the fix for #3050.

We can close this.

comment:5 Changed 6 days ago by mjethani

  • Owner set to mjethani

comment:6 Changed 6 days ago by mjethani

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.