Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3071 closed defect (fixed)

Element Hiding Helper broken in Thunderbird/SeaMonkey Mail

Reported by: trev Assignee: trev
Priority: P1 Milestone: Element-Hiding-Helper-1.3.5
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Thunderbird
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29327605/

Description

Environment

Thunderbird 38.2.0 or SeaMonkey 2.35 on OS X 10.10, Adblock Plus 2.6.10.3972-beta, Element Hiding Helper 1.3.4.508-beta.

How to reproduce

  1. Open a mail in Thunderbird or SeaMonkey Mail.
  2. Click ABP icon and choose "Select an element to hide"
  3. Click an element in the mail

Observed behaviour

Nothing happens, the error message "TypeError: this.browser.selectedBrowser is undefined" shows up in Error Console (pointing to aardvark.js line 615).

Problem is that the code here is expecting this.browser to be a <tabbrowser> whereas on Thunderbird and in SeaMonkey Mail we get a regular <browser> element.

Expected behaviour

The filter assistant should show up.

Change History (3)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/elemhidehelper/rev/d17f6f0a3801

comment:3 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

ABP 2.6.13 / EHH 1.3.5
Thunderbird 38.2.0 / Ubuntu 14.04
Thunderbird 38.4.0 / Ubuntu 14.04

Note: See TracTickets for help on using tickets.