Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3073 closed defect (fixed)

Adblock Browser doesn't display acceptable ads on ebay.com (mobile version) and walmart.com

Reported by: philll Assignee:
Priority: P1 Milestone: Adblock-Browser-for-iOS-1.2.0
Module: Adblock-Browser-for-iOS Keywords: salsita
Cc: fhd, philll, sebastian, oleksandr, mario, sergz, Shikitita Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mario)

Environment

Iphone 5S
iOS 8.4
Adblock Browser (core 1.3.0) build qa-455
Easylist
Acceptable Ads enabled

How to reproduce

  1. Go to http://www.ebay.com/sch/i.html?_odkw=&_osacat=33829&_from=R40&_trksid=p2045573.m570.l1311.R5.TR12.TRC2.A0.H0.Xiphone.TRS0&_nkw=iphone+6&_sacat=33829 or http://www.walmart.com/search/?query=car%20rental&typeahead=car%20rental
  2. Scroll all the way down

Observed behaviour

Under the paging bar, there is an empty space.

Expected behaviour

Google sponsored links should show as when you open the page with Google Chrome for Desktop and ABP enabled or with ABP disabled in Adblock Browser for iOS.

Remark for testers

The observed behaviour was fixed for the following use cases:

The observed behaviour was not fixed for the desktop version of http://www.ebay.com/ as it was removed from the scope of this issue. However this problem was moved to #3360.

Attachments (1)

ebay_advertisement.png (421.4 KB) - added by mario 4 years ago.
eBay Advertisement

Download all attachments as: .zip

Change History (25)

comment:1 Changed 4 years ago by philll

  • Description modified (diff)

comment:3 Changed 4 years ago by pavelz

  • Cc fhd philll sebastian added

comment:4 Changed 4 years ago by pavelz

So switching the fallback type to other did not fix ebay sponsored links. Comparing with your IE blocker behavior would be useful confirmation. So leaving it at image for now, will be working on more deterministic solution toward the next release.

comment:6 Changed 4 years ago by philll

With Adblock Plus for IE 1.4.798, the whitelisted ads on both sites show as expected with Acceptable Ads enabled in a 64 bit IE11 on 64 bit Win7.

comment:7 Changed 4 years ago by sebastian

  • Cc oleksandr added

Note that the logic in IE is more complex than just the function you linked, that if I understand correctly, only tries to associate types to file extensions as a last resort, while headers are considered first. Maybe Ollie, can explain the logic we use in IE to determine the type of a request better?

Last edited 4 years ago by sebastian (previous) (diff)

comment:8 Changed 4 years ago by oleksandr

Yes, in IE we essentially try to get the mime type first, and only if we fail to get the mime type we try to get the content type from URL. Here is the full function:
https://github.com/adblockplus/adblockplusie/blob/master/src/plugin/PluginWbPassThrough.cpp#L199
Note that we search for the extension first in the URL and then in the query string.
We also assume that requests that do not have parent requests are XMLHttpRequest.

comment:9 Changed 4 years ago by oleksandr

By "get the mime type", I mean we try to extract the value of HTTP Accept header of the request. We do this before the request is actually issues, obviously.

comment:10 Changed 4 years ago by mario

  • Cc mario added

comment:11 Changed 4 years ago by mario

  • Component changed from Unknown to Adblock-Browser-for-iOS

comment:12 Changed 4 years ago by mario

  • Keywords salsita added

comment:13 Changed 4 years ago by Shikitita

I'm regressing this issue at the moment, in regards to Walmart, and the website's behaviour is really unreliable. The acceptable ads are never displayed with the first results of the very first search on the website. However, they are sometimes when refreshing the page or when disabling and enabling adblock plus.

It might be random, unfortunately, but the acceptable ads are displayed, so I will accept it in Pivotal.

comment:14 Changed 4 years ago by pavelz

  • Resolution set to fixed
  • Status changed from new to closed

comment:15 Changed 4 years ago by mario

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:16 Changed 4 years ago by mario

  • Status changed from reopened to reviewing

comment:17 Changed 4 years ago by mario

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:18 Changed 4 years ago by mario

  • Milestone set to Adblock-Browser-for-iOS-next

comment:19 Changed 4 years ago by Shikitita

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'm afraid this issue is still occurring but only for the classic/desktop site, not for the mobile site. Acceptable Ads are only displayed when ABP is disabled, regardless if the AA option was disabled or enabled previously.

comment:20 Changed 4 years ago by sergz

  • Cc sergz added

comment:21 Changed 4 years ago by pavelz

  • Cc Shikitita added

Sponsored ads on Walmart stopped displaying for me completely - even with another browser. Might be a change in location awareness. But you may have been talking only about eBay, as i see an obvious way of switching to Classic Site there, not on Walmart. So regarding eBay, i need to know how a sponsored ad ON CLASSIC SITE is supposed to look like. I don't see anything like Acceptable Ad on eBay classic site - even with real desktop browsers.

Changed 4 years ago by mario

eBay Advertisement

comment:22 Changed 4 years ago by mario

Replying to pavelz:

So regarding eBay, i need to know how a sponsored ad ON CLASSIC SITE is supposed to look like. I don't see anything like Acceptable Ad on eBay classic site - even with real desktop browsers.

  1. Go to ebay.com
  2. Switch to desktop site at the bottom of the page (if necessary)
  3. Search for "iPhone"
  4. "Sponsored Links" are displayed at the bottom of the page right below the search results

-> See screenshot

Last edited 4 years ago by mario (previous) (diff)

comment:23 Changed 4 years ago by mario

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reopened to closed

I've removed eBay desktop (only remaining problem) from the scope of this issue and moved it to #3360. I've also outlined the change of scope in the issue's description.
Fixes for eBay mobile and Walmart mobile have landed and this very issue can be closed.

comment:24 Changed 4 years ago by mario

  • Summary changed from Adblock Browser doesn't display acceptable ads on ebay.com and walmart.com to Adblock Browser doesn't display acceptable ads on ebay.com (mobile version) and walmart.com
Note: See TracTickets for help on using tickets.