Opened 3 years ago

Last modified 3 years ago

#3074 new defect

Adblock Browser for iOS doesn't trigger file download

Reported by: philll Assignee:
Priority: Unknown Milestone:
Module: Adblock-Browser-for-iOS Keywords:
Cc: mario Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

Iphone 6 plus
iOS 9.1
Adblock Browser 1.1.0 qa-455

How to reproduce

  1. Open http://placement24.com/en/public/press/downloads/p24_images.zip or https://issues.adblockplus.org/raw-attachment/ticket/3061/notification-firefox-overlays-chrome.png

Observed behaviour

The first link makes the loading progress bar to show up but never finish. The second link displays the image instead of downloading it. No downloads seem to happen.

Expected behaviour

The files should download to the device.

Change History (7)

comment:1 Changed 3 years ago by pavelz

Saving images to Camera Roll is obvious and possible. Anything non-media (like zips) is also possible but not as straightforward. You can't "save" the file in a generally accessible place like on Android - media is an exception. Non-media can only stay in the app sandbox. So other iOS browsers generally do show a selection of sharing options, basically the same as when clicking "Share" in the main ABB menu. But there needs to be a visual feedback about the downloaded file. See other browsers for inspiration about how ABB should behave.

comment:2 Changed 3 years ago by mario

  • Cc mario added
  • Component changed from Unknown to Adblock-Browser-for-iOS

comment:3 Changed 3 years ago by mario

  • Keywords salsita added

comment:4 Changed 3 years ago by pavelz

https://www.pivotaltracker.com/story/show/103577470
Porting over a comment in PT from Vojta Burian:

For now, show that file cannot be downloaded (not supported) like Safari does.

Please confirm this as an official requirement.
I know we have talked about it at length, but it contradicts the current Expected behaviour. And Trac is the new authoritative source of requirements.

Also regarding Reproduction steps:

The first link makes the loading progress bar to show up but never finish

This is an undisputable UX glitch to fix, but

The second link displays the image instead of downloading it. No downloads seem to happen.

this is normal behavior. If the content is directly displayable by the browser, like an image or supported video format, it gets displayed directly. Download is reachable only through long-tapping. This applies to Safari as well as any 3rd party browser.

Please clarify the required behavior.

comment:5 Changed 3 years ago by mario

This hasn't been set ready, as the issue needs to be revised completely. As discussed in Slack, #3160 can be tackled first, which only addresses image downloads. File downloads in general need to be revised.

So, yes, handling file-downloads is a requirement - but we'll need to update this very issue to fit our needs and the app's design before it can be set ready.

comment:6 Changed 3 years ago by pavelz

  • Ready unset

comment:7 Changed 3 years ago by pavelz

  • Keywords salsita removed

Feature spec needed, removed salsita keyword

Note: See TracTickets for help on using tickets.