Opened 4 years ago

Closed 4 years ago

#3094 closed change (fixed)

adblock_browser_android_store should redirect requests from China to adblock_browser_android_download

Reported by: fhd Assignee: matze
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: greiner, matze, fred, vickyyu, mario Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329111

Description

Background

Google Play is not available in China, so sending people from China there does not make that much sense. Instead, we should offer them our standalone builds. In a follow-up, we can offer Chinese users more options, but for now this should do.

What to change

Redirect requests to https://adblockplus.org/redirect?link=adblock_browser_android_store that originated from China to https://adblockplus.org/redirect?link=adblock_browser_android_download.

Note that this should not be deployed until #3047 made it into a release.

Change History (8)

comment:1 Changed 4 years ago by greiner

  • Cc greiner added

You want an internal redirect, right? Because I don't see why we should redirect the browser twice since we already know the final destination anyway.

comment:2 Changed 4 years ago by matze

  • Cc matze fred added
  • Priority changed from Unknown to P2

comment:3 Changed 4 years ago by vickyyu

  • Cc vickyyu added

comment:4 Changed 4 years ago by mario

  • Cc mario added

comment:5 Changed 4 years ago by matze

  • Owner set to matze

comment:6 Changed 4 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 4 years ago by vickyyu

By using a Chinese VPN, when I clicked on the Android button, the apk was directly downloaded. The only problem is that the download speed is very slow.

comment:8 Changed 4 years ago by matze

  • Ready set
  • Resolution set to fixed
  • Status changed from reviewing to closed

Thank you for your feedback, I'll close this ticket now.

Regarding the download speed, if you think it's worth investigating please open up a new ticket, and include info like e.g. whether this affects the ABB download only, how it compares to a download without the route through China, if the community reports similar trouble, and some numbers about the time it takes. Thank you!

Note: See TracTickets for help on using tickets.