Opened 4 years ago

Closed 8 weeks ago

#3096 closed defect (rejected)

Notification icon animation is not stopped after desktop notification is dismissed

Reported by: Ross Assignee:
Priority: P3 Milestone:
Module: Platform Keywords: closed-in-favor-of-gitlab
Cc: fhd, sebastian, greiner, jsonesen, kzar Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Ross Verified working: no
Review URL(s):

Description

Environment

ABP 1.9.2.1482
Chrome 45.0.2454.93 m / Ubuntu 14.04 - 64bit
Opera 32.0.1948.25 / Windows 7 - 32bit

How to reproduce

  1. Create a notification.json like below and serve it.
  2. Set the ABP notification URL to served notification.json.
  3. Clear Prefs.notificationdata.
  4. Restart Chrome.
  5. Wait one minute.
  6. Observe desktop notification with button appear.
  7. Select the button on the notification.
  8. Observe link is opened, notification is dismissed.
  9. Wait ~10s. Observe ABP icon performs ! animation.
  10. Select the ABP icon to open the popup UI.
  11. Observe there is no notification present. Leave popup UI open.
  12. Observe ABP icon perform ! animation again (and so on).

Observed behaviour

When selecting a link in a desktop notification, the desktop and popup UI notification are dismissed/closed however the icon keeps animating.

Expected behaviour

If the notification has been dismissed already the animation should be stopped.

Test data

{
  "notifications": [
    {
      "id": 1,
      "type": "critical",
      "title": "Title",
      "message": "Notification with <a>link</a>",
      "links": [ "link" ]
    }
  ],
  "version": "201509161000"
}

Change History (3)

comment:1 Changed 4 years ago by kzar

  • Ready set

comment:2 Changed 2 years ago by sebastian

  • Cc jsonesen kzar added

Ross just reminded me of this issue. Does anybody want to look into it? :)

comment:3 Changed 8 weeks ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.