Opened 21 months ago

Closed 20 months ago

Last modified 19 months ago

#3108 closed defect (fixed)

Firefox Nightly elements no longer works

Reported by: fanboy Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s 2015q4
Cc: arthur, mapx Blocked By: #3227, #3290
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29329154/
https://codereview.adblockplus.org/29329246/
https://codereview.adblockplus.org/29329259/
https://codereview.adblockplus.org/29329263/

Description

Environment

Launch Firefox Nightly (latest)

How to reproduce

  1. With Adblock Plus-Dev installed open a website (such as http://www.nzherald.co.nz/ )
  1. NS_ERROR_DOM_BAD_URI: Access to restricted URI denied1 RemoteAddonsChild.jsm:283:0

Security Error: Content at http://www.nzherald.co.nz/ may not load data from about:abp-elemhidehit?154911587633.

  1. Elements don't hide because of this error message

Change History (22)

comment:1 Changed 21 months ago by trev

  • Component changed from Unknown to Adblock-Plus-for-Firefox
  • Priority changed from Unknown to P1
  • Ready set

This is a regression from bug 1204703 it seems. For some reason I cannot see this error message but I do see the impact of it.

comment:2 follow-up: Changed 21 months ago by fanboy

Do we need a fix in Firefox or is there a fix coming for ABP?

comment:3 Changed 21 months ago by Evengard

Actually it seems that it is trying to hiding elements, but the exception rules doesn't work. https://reports.adblockplus.org/2b43eb3d-9c14-4bca-8063-72b059fea000#tab=screenshot here is a report of one of such behaviour. Even more it doesn't show that it hid elements in the hiding log. And seems to actually lag a lot because of that.

I would considering this as very important, but not sure if this is ABP or Firefox bug.

comment:4 Changed 21 months ago by Evengard

Reported on Firefox issue tracker here: https://bugzilla.mozilla.org/show_bug.cgi?id=1213646 let's see their answer.

comment:5 in reply to: ↑ 2 Changed 21 months ago by trev

Replying to fanboy:

Do we need a fix in Firefox or is there a fix coming for ABP?

Unfortunately, that depends on whether ABP is making wrong assumptions or the new security checks have a bug - and that's not exactly easy to say.

comment:6 Changed 21 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

After looking some more into this, the issue can be fixed on our end.

comment:7 Changed 21 months ago by trev

My bad, this only fixes it as long as E10S isn't enabled. While this change is certainly necessary, in E10S mode we still have the same issue - it seems that the about: protocol handler will do security checks before even consulting us.

comment:8 Changed 21 months ago by trev

  • Status changed from reviewing to reopened

First part has been pushed: https://hg.adblockplus.org/adblockplus/rev/9d2fcc878593

Fixing the rest of it requires getting our about: protocol handler into the content process instead of the compatibility shim. Working on that.

comment:9 Changed 21 months ago by trev

  • Owner set to trev

comment:10 Changed 21 months ago by trev

  • Keywords e10s added
  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

Second change fixes the remaining parts now. Side-effect is that element hiding hits will no longer appear in the blockable items window (still visible via Diagnostics extension). This issue requires #3208 to be fixed first.

comment:11 Changed 21 months ago by arthur

  • Cc arthur added

comment:12 Changed 21 months ago by trev

Pushed the second change: https://hg.adblockplus.org/adblockplus/rev/c1f6680dd416

Leaving the issue open in order to clean up a bit.

comment:13 Changed 21 months ago by trev

  • Review URL(s) modified (diff)

comment:14 Changed 21 months ago by trev

  • Review URL(s) modified (diff)

comment:15 Changed 20 months ago by Evengard

The version before the cleanup (the one within the ABP dev build) seems to be working on latest Firefox Alpha (2015-10-18)

comment:16 Changed 20 months ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Last edited 20 months ago by trev (previous) (diff)

comment:17 Changed 20 months ago by Evengard

It seems to also work, but I've got the problem of twitch video ads not being blocked. I'm not sure this is related to theese changes, but even yesterday all was alright. But well it could be that they updated something on twitch.

comment:18 Changed 20 months ago by trev

  • Blocked By 3227 added

comment:19 Changed 20 months ago by mapx

  • Cc mapx added

comment:20 Changed 20 months ago by mario

  • Keywords 2015q4 added

comment:21 Changed 20 months ago by trev

  • Blocked By 3290 added

comment:22 Changed 19 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Element hiding works again in Nightly.

ABP 2.6.13.4091-beta
Firefox 45 Nightly (2015-12-13) / Ubuntu 14.04

Last edited 19 months ago by Ross (previous) (diff)
Note: See TracTickets for help on using tickets.