Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3110 closed defect (fixed)

[Adblock Browser for iOS] Acceptable Ads blocked in Yelp website

Reported by: Shikitita Assignee:
Priority: Unknown Milestone: Adblock-Browser-for-iOS-1.2.0
Module: Adblock-Browser-for-iOS Keywords:
Cc: pavelz, vojtab, jand, Shikitita Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

Platform: iPhone 5s
Operating system: iOS 8.4
Browser: Adblock Browser for iOS v. 1.1.0 (476)

How to reproduce

  1. Install and launch Adblock Browser
  2. Tap on the URL Search bar at the top of the screen in order to enter the following link: http://www.yelp.com/search?find_desc=tacos&find_loc=San+Francisco%2C+CA%2C+USA&ns=1
  3. Disable ABP in the browser tapping on the icon displayed in the middle at the bottom of the screen and then unchecking "Ad blocking on this site"
  4. Refresh the website by tapping on the refresh icon displayed inside the URL Search bar on the right side

Observed behaviour

There are no ads displayed when ABP is enabled in the browser. An attempt to display them can be seen when loading the link for the first time with Acceptable Ads and ABP enabled.

Expected behaviour

Acceptable Ads shouldn't be blocked even if ABP is enabled. The correct behaviour can be observed when checking the same link with Google Chrome.

Attachments (1)

IMG_0126.PNG (146.8 KB) - added by Shikitita 4 years ago.
Acceptable Ad displayed with "Ad blocking on this site" disabled

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by Shikitita

Acceptable Ad displayed with "Ad blocking on this site" disabled

comment:1 Changed 4 years ago by pavelz

An attempt to display them can be seen when loading the link for the first time with Acceptable Ads and ABP enabled

This observation is absolutely correct. The Ad offers are there, it's not blocked, just hidden by CSS. The AA is not in subframe, so the main frame is getting wrong CSS.

comment:2 Changed 4 years ago by pavelz

https://www.pivotaltracker.com/story/show/104528670

Background script was getting a sender frame with Referer form of URL, ie. compatible with WebKit Referer headers - no query part. The whitelist filter is expecting a complete URL, therefore didn't match. Yelp specifically wants to find the questionmark which is opening the query part.

comment:3 Changed 4 years ago by pavelz

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 4 years ago by mario

  • Milestone set to Adblock-Browser-for-iOS-next
Note: See TracTickets for help on using tickets.