Opened 4 years ago

Closed 4 years ago

#3117 closed change (fixed)

Restrict "prefixes" attribute in recommendations.xml to subscriptions that specify languages

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: Sitescripts Keywords: goodfirstbug
Cc: kzar Blocked By:
Blocking: #2821 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29334078/

Description

Background

Both subscriptions.xml and subscriptions2.xml templates include a condition that ensures that the "prefixes" attribute is only added to <subscription> if the subscription specifies at least one language. So far recommendations.xml didn't need this condition since all recommended subscriptions do specify languages. But with the introduction of non-"ads" type subscriptions to that list in #2825 this will change. Therefore we need to add this condition to recommendations.xml.

What to change

Ensure to only include prefixes="{{subscription.languages}}" in the template for recommendations.xml for subscriptions that specify languages. The resulting recommendations.xml shouldn't differ from the current one.

Change History (4)

comment:1 Changed 4 years ago by kzar

  • Cc kzar added
  • Keywords goodfirstbug added
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 4 years ago by greiner

  • Owner set to greiner

comment:3 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.