Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3119 closed change (fixed)

Remove unnecessary build steps from adblockbrowser-build

Reported by: rjeschke Assignee: rjeschke
Priority: P2 Milestone: Adblock-Browser-for-Android-1.1.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29328578/

Description

package-en-US and restore-objdir are not needed for a multi locale build and can safely be removed.

  • package-en-US is only needed when also using upload-en-US
  • restore-objdir is only needed when also using backup-objdir

The complete default_actions then should look something like this:

"default_actions": [
    "pull-locale-source",
    "build",
    "add-locales",
    "abb-transform-locales",
    "package-multi",
    "summary"
]

Change History (3)

comment:1 Changed 4 years ago by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 4 years ago by fhd

  • Milestone set to Adblock-Browser-for-Android-next
Note: See TracTickets for help on using tickets.