Opened 4 years ago

Closed 3 months ago

#3122 closed change (fixed)

Add sitescripts.testpages.web.sitekey_frame URL handler

Reported by: kzar Assignee: kzar
Priority: P4 Milestone:
Module: Sitescripts Keywords: testpages
Cc: Ross, sebastian, philip@…, greiner Blocked By: #3339
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29328589/
https://codereview.adblockplus.org/29328600/
https://codereview.adblockplus.org/29329256/

Description

Background

testpages.adblockplus.org contains some test pages that we give to our Adblock Plus testers to test the various extensions. So far these pages have only required static content, nothing dynamically generated. However, to properly test the $sitekey filter option functionality we now need a pages to be dynamically generated.

What to change

Create a URL handler in sitescripts.testpages.web.sitekey_frame that responds to web requests, returning the proper X-Adblock-Key header. The template rendered for the body should be configurable, and the template should be provided with two variables: signature and public_key.

Document the new functionality and make the required corresponding changes to the testpages.adblockplus.org repository.

Note: This issue does not include adding comprehensive test cases for the $sitekey option, but only the prerequisite code that they require.

Change History (11)

comment:1 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)

comment:5 Changed 4 years ago by kzar

  • Priority changed from Unknown to P4
  • Ready set

comment:7 Changed 4 years ago by kzar

  • Blocked By 3339 added

comment:8 Changed 3 years ago by kzar

  • Owner kzar deleted

I've just been looking through old issues I'm assigned to. The prerequsite work here was done but I don't think we ever actually added $sitekey tests cases to https://testpages.adblockplus.org.

Ross If you get a chance maybe add one?

  1. The testpages filter subscription contains a whitelist filter for the testpages sitekey
  2. The URL https://testpages.adblockplus.org/sitekey-frame#/path/to/testcase will create an iframe the size of the whole window with the src path of /path/to/testcase. It will also set up the correct $sitekey header.

So if you create a test case with something that would normally be blocked you can link to it with the sitekey-frame URL and it will no longer be. That way you can create a test case to confirm that $sitekey whitelisting is working.

comment:9 Changed 3 months ago by kvas

Dear stakeholders of this ticket,

I'm cleaning up Sitescripts tickets in Trac due to its phase out. This is one of the tickets that I could not myself close or move, so I need your input on it.

Please let me know if this ticket is still relevant for you and we can then discuss where it should be moved. If you think that this ticket is no longer relevant, you can write a comment explaining this or just ignore this message.

If I see now comments in the ticket on October 14, I will close it as rejected.

Best regards,
Vasily

comment:10 Changed 3 months ago by greiner

  • Cc greiner added
  • Owner set to kzar

comment:11 Changed 3 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

I guess I just forgot to close this one, since it does work. Marking as fixed.

Note: See TracTickets for help on using tickets.