Opened 4 years ago

Closed 4 years ago

#3124 closed change (fixed)

Allow the new severity value "normal"

Reported by: fhd Assignee:
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #3125 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29328652/

Description

Background

#3022 added a new notification severity, normal, but the notification parser only allows information or emergency.

What to change

Allow the normal severity in the notification parser.

Change History (4)

comment:1 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by fhd

  • Blocking 3125 added

comment:3 Changed 4 years ago by fhd

Had to push this pre-review due to time constraints: https://hg.adblockplus.org/sitescripts/rev/c969ce512008

comment:4 Changed 4 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Reviewed now.

Note: See TracTickets for help on using tickets.