Opened on 09/25/2015 at 10:19:42 AM

Closed on 09/25/2015 at 11:59:08 AM

#3125 closed change (fixed)

Improve the second Adblock Browser notification test

Reported by: fhd Assignee:
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By: #3124
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by fhd)


We have started the second notification test last night, see:

However, there are some problems. We had to reopen #2981, because it is still not solved, and thus the test sample is too large. We also forgot to consider testing the new normal notification type in Chrome (#3020).

What to change

Modify notification 2:

  1. Change severity to normal
  2. Change links for each variant: adblock_browser_promotion_1 should become adblock_browser_promotion_4, adblock_browser_promotion_2 should become adblock_browser_promotion_5 and adblock_browser_promotion_3 should become adblock_browser_promotion_6. (Otherwise we can't tell which were clicked from an notification of the previous type.)
  3. Change sample for each variant from 0.017 to 0.005. (This will put at least 1.5% of the users into one of the test groups - very likely more, because of #2981.)

Attachments (0)

Change History (8)

comment:1 Changed on 09/25/2015 at 10:20:46 AM by fhd

  • Description modified (diff)

comment:2 Changed on 09/25/2015 at 10:23:55 AM by fhd

  • Description modified (diff)

comment:3 Changed on 09/25/2015 at 10:26:37 AM by fhd

  • Description modified (diff)

comment:4 Changed on 09/25/2015 at 10:30:03 AM by fhd

  • Description modified (diff)

comment:5 Changed on 09/25/2015 at 10:31:19 AM by fhd

  • Summary changed from Improve the second notification test to Improve the second Adblock Browser notification test

comment:6 Changed on 09/25/2015 at 10:32:26 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 09/25/2015 at 10:57:32 AM by fhd

Had to push this pre-review due to time constraints:

comment:8 Changed on 09/25/2015 at 11:59:08 AM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Reviewed now.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.