Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3129 closed defect (fixed)

Rules cannot be edited if "Search for text when I start typing" is enabled

Reported by: Ac Assignee: trev
Priority: Unknown Milestone: Adblock-Plus-2.6.12-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: greiner, trev, mapx Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29328828/
https://codereview.adblockplus.org/29329848/

Description (last modified by greiner)

Environment

Windows 7 x64
Firefox 41.0
Adblock Plus 2.6.11
No filter list is used

How to reproduce

  1. Go to Firefox Options -> Advanced -> General and make sure the option "Search for text when I start typing" is switched on
  2. Get to Adblock Plus and double click any rule to start editing
  3. Type any character (like "a") and it will go to now opened Findbar to fill it, not to the rule name.

Observed behaviour

While editing a rule the typed characters are filling the Findbar, not the rule name.

Expected behaviour

If you edit the rule what you type should get to the rule name, not Findbar.

This was broken in 2.6.11, version 2.6.10 works fine.

What to change

Make sure that in "filters.xul" #findbar's "_findAsYouType" property is set to false to prevent the findbar from being opened by interactions with the filter tree. This property reflects the value of the accessibility.typeaheadfind preference which is the one behind the "Search for text when I start typing" option.

Change History (13)

comment:1 Changed 4 years ago by mapx

see #2580

comment:2 Changed 4 years ago by mapx

  • Resolution set to duplicate
  • Status changed from new to closed

comment:3 Changed 4 years ago by Ac

This bug seems different from #2580. It reveals itself only after the last ABP version (2.6.11). So they should not be duplicated, maybe just linked.

comment:4 Changed 4 years ago by mapx

  • Cc greiner trev mapx added

comment:5 Changed 4 years ago by greiner

  • Component changed from Unknown to Adblock-Plus-for-Firefox
  • Resolution duplicate deleted
  • Status changed from closed to reopened

comment:6 Changed 4 years ago by greiner

  • Description modified (diff)

Added "What to change" section to get this ticket to ready state.

comment:7 Changed 4 years ago by trev

  • Ready set

comment:8 Changed 4 years ago by greiner

  • Owner set to greiner

comment:9 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:10 Changed 4 years ago by trev

  • Owner changed from greiner to trev

comment:11 Changed 4 years ago by trev

  • Review URL(s) modified (diff)

Let's try a different approach.

comment:12 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:13 Changed 4 years ago by trev

  • Milestone changed from Adblock-Plus-for-Firefox-next to Adblock-Plus-2.6.12-for-Firefox

Adblock Plus 2.6.12 is being released from branch, this change is part of it.

Note: See TracTickets for help on using tickets.